Opened 4 years ago

Closed 4 years ago

#162 closed defect (fixed)

libodin requires sed for %post scriptlet, but sed is not listed as dependency of libodin

Reported by: Lewis Rosenthal Owned by:
Priority: minor Milestone:
Component: spec files Version:
Severity: low Keywords:


I am only discovering this since building the i686 and pentium4 bootstrap packages, which do not include either sed or libodin. Installing libodin without sed throws a bunch of errors apparently from the %post scriptlet, though libodin seems to be installed correctly (and is able to be uninstalled).

Suggest adding sed to list of prerequisites for the package.

sed: not found
sed: not found
sed: not found
sed: not found
mkdir: cannot create directory `': No such file or directory
sed: not found

  libodin.i386 0:0.8.9-1

Change History (4)

comment:1 Changed 4 years ago by Silvan Scherrer

sed in my opinion should be installed by default always. as a lot stuff needs it.

comment:2 Changed 4 years ago by Lewis Rosenthal

No argument, however, sed has dependencies:

doscalls    - provided by os2-base
gcc446.dll  - provided by libgcc-fwd
kintl.dll   - provided by gettext-libs; gettext-legacy
libc064.dll - provided by libc
urpo.dll    - provided by urpo

Not all of these are installed by the bootstrap (even my latest "fixed" ones). Unfortunately, nothing called from yum install yum requires sed, so it doesn't get pulled down then, either.

So, either we add this to the bootstrap, along with dependencies, or it needs to be added to the spec for those packages needing it for a scriptlet.

I looked at updating my updated bootstrap builds from ticket #158 last night, and I stopped when I noticed the dependencies. I figured we should kick this around first.

comment:3 Changed 4 years ago by Silvan Scherrer

the real solution is of course to have a req for sed in the odin.spec. as every spec should have all req listed.

comment:4 Changed 4 years ago by Yuri Dario

Resolution: fixed
Status: newclosed

Since rpm scripts are using sed, it makes sense to add it as requirement for rpm installation.

rpm, add sed as requirement, fixes ticket#162.
Committed revision r638

Note: See TracTickets for help on using tickets.