Opened 13 years ago

Closed 13 years ago

#16 closed enhancement (fixed)

Allows dot as valid char for dll names

Reported by: ydario Owned by: bird
Priority: normal Milestone: libc-0.6
Component: emx Version: 0.6
Severity: normal Keywords: def emxbind weakld
Cc:

Description

The .def library parser doesn't allow dots inside names for DLL.

This patch will enable it:

Index: moddef2.c
===================================================================
RCS file: /netlabs.cvs/libc/src/emx/src/libmoddef/moddef2.c,v
retrieving revision 1.1.1.2
diff -r1.1.1.2 moddef2.c
125a126,132
>       if (token == _MD_dot)
>         {
>           _strcat( stmt.library.name, ".");
>           token = _md_next_token (md);
>           _strcat (stmt.library.name, _md_get_string (md));
>           token = _md_next_token (md);
>         }

Change History (3)

comment:1 Changed 13 years ago by bird

The patch is not addressing the problem correctly. What if you have more than one '.' in the name?

comment:2 Changed 13 years ago by bird

  • Component changed from libc to emx
  • Keywords def emxbind weakld added
  • Milestone set to libc-0.6
  • Severity changed from normal to enhancement
  • Version set to 0.6

I've made an attempt to fix this properly (http://svn.netlabs.org/libc/changeset/2449). Btw. you could simply have quoted the name...

comment:3 Changed 13 years ago by bird

  • Resolution set to fixed
  • Status changed from new to closed

This works fine with emxomfld. In the a.out world, the .def-file is not respected and the -o argument is used to determin the internal name.

Note: See TracTickets for help on using tickets.