Opened 14 years ago

Closed 14 years ago

#143 closed defect (fixed)

Linguist build fails.

Reported by: rudi Owned by:
Priority: major Milestone: Qt 4.6.2
Component: Tools Version:
Severity: low Keywords:
Cc:

Description

tools\linguist\linguist\mainwindow.cpp

doesn't honour QT_NO_PRINTER. There are several locations in the source where m_printer gets accessed.

Change History (5)

comment:1 Changed 14 years ago by Dmitry A. Kuminov

This must be the result of merging 4.6.1 because in 4.5.1 beta 4 for OS/2 we didn't have printing support but Linguist worked. Anyway, r662 should fix that, please check.

comment:2 Changed 14 years ago by rudi

No, that's not enough. They decided not declare the member variable m_printer at all in case QT_NO_PRINTER is defined (mainwindow.h). Thus we have to add an #ifdef around line 261 and completely disable MainWindow::printer(), which is only referenced by MainWindow::print().

comment:3 Changed 14 years ago by Dmitry A. Kuminov

Ah it was actually my typo (missing #else case which returns 0 instead of m_printer). Anyway, I redid in a slightly different way in r663.

comment:4 Changed 14 years ago by rudi

O.K, works "out of the box" now.

comment:5 Changed 14 years ago by Dmitry A. Kuminov

Resolution: → fixed
Status: new → closed

Ok.

Note: See TracTickets for help on using tickets.