Opened 8 years ago

Closed 8 years ago

#153 closed enhancement (fixed)

nspr: Make code involving file names use kLIBC instead of Dos APIs

Reported by: dmik Owned by:
Priority: major Milestone:
Component: nspr Version:
Severity: medium Keywords:
Cc: dryeo

Description

This is necessary to properly support kLIBC symlinks. Typical failures are like this one: https://github.com/bitwiseworks/mozilla-os2/issues/198.

Change History (3)

comment:1 by dryeo, 8 years ago

Cc: dryeo added

comment:2 by dmik, 8 years ago

In r2186 I got rid of all Dos* calls in file manipulation NSPR APIs (living in os2io.c). The code looks much simpler now as all hacks like high mem and large file support support are under the kLIBC hood now. And it's all of course symlink friendly (including file copying, removal and so on). I got it a quick test with the latest FF, all issues described in https://github.com/bitwiseworks/mozilla-os2/issues/198 have gone.

I will give it some more testing before closing this ticket and releasing.

Note that the current trunk is not configurable ATM as there is an autoconf bug that prevents us from using options with spaces in LDFLAGS and other similar variables (e.g. a typical "-Zlinker 'DISABLE 1121' to kill the infamous and highly annoying "symbol is already exported" WLINK warning). I have autoconf already hacked locally that works well so I will commit it in a while. See #156 for details.

comment:3 by dmik, 8 years ago

Resolution: fixed
Status: newclosed

After fixing one regression in r2187 It works quite well in the current state (Firefox is a good test case). Closing this. A new RPM is about to be released soon.

Note: See TracTickets for help on using tickets.