Opened 2 years ago
Fix loading icons from resources
|Reported by:||dmik||Owned by:|
Certain icon formats are loaded from the EXE/DLL resources incorrectly. The following problems are seen in WinRAR 4.0 GUI:
- Shifted AND masks (Help -> About WinRAR... -> the jumping stack of books under the logo).
- Wrong color depth (the jumping stack of books, if I hack the AND mask manually, looks like a 16-color image while under Win7 it's a full color image -- this may be a consequence of selecting an inappropriate version of the icon from the resource).
- Wrong icon dimensions reported (the tool button width in the main window doesn't fit the icon so the icons are drawn overriding each other).
These problems seem to affect the CreateIconFromResource?()/LoadImage?() APIs. Since these APIs seem not to be used in e.g. Java or Flash, the above problems don't affect these apps. Instead they affect native Win32 apps (which usually supply the icons in the resources).