Opened 5 years ago

Last modified 5 years ago

#336 new defect

linking high-mem enabled modules and high-mem disabled modules together

Reported by: komh Owned by:
Priority: normal Milestone: libc-0.7
Component: libc Version: 0.6.6
Severity: normal Keywords:
Cc:

Description

Hi/2.

When linking high-mem enabled modules and high-mem disabled modules together, high-mem is not enabled. For example, in case of high-mem enabled executable linked against high-mem disabled DLLs, high-mem is not enabled.

This is because __libc_HeapVote() does not set enmResult to enmHigh never once it is set to enmLow. Is this an intention or a bug ?

Anyway, this does not look correct. I think, the way to go is to enable high-mem by default even if -Zhigh-mem is not specified. kLIBC already includes os2safe.h by default.

Change History (3)

comment:1 Changed 5 years ago by ydario

This is intentional. If a dll is not highmem enabled, it is not safe to pass a highmem data pointer to it.

comment:2 Changed 5 years ago by komh

Then, it would be better to use _lmalloc for those dlls rather than to disable high-mem feature itself at all.

Anyway, making a high-mem feature default is needed sometime. How about ?

comment:3 Changed 5 years ago by dmik

This not strictly belongs here but somewhat related. We've run in to an interesting case here when building PE/PEC from Odin. There we use -nostdlib which disables the standard C library (including things like __lmalloc). However, since os2safe.h is now included by default, this will always give unresolved exports if the program uses any of Dos calls for which we have wrappers. The only solution is to use -DNO_INCLUDE_SAFE_HIMEM_WRAPPERS in this case.

This raises the same question again (already discussed elsewhere): -Zhigh-mem, inclusion of os2safe.h and (now) the -nostdlib switch should somehow correlate. E.g. like this:

  1. If -Zhigh-mem is given, os2safe.h is included by default, otherwise it is not.
  2. If both -nostdlib and -Zhihg-mem are given, gcc aborts with an error about incompatible options.
Note: See TracTickets for help on using tickets.