Opened 12 years ago

Closed 6 years ago

#204 closed defect (fixed)

chown/chgrp functions are only stubs, proposed fix

Reported by: YDARIO Owned by: Yuri Dario
Priority: normal Milestone: libc-0.6.6
Component: libc-backend Version: 0.6.2
Severity: normal Keywords: chgrp chown
Cc:

Description

The two functions chown/chgrp are only stubs for validating file path and nothing more.

The attached code implements setting/getting the two fields; it misses code validation for current user, to check if he has enough rights to operate.

Attachments (3)

chown-grp.txt (15.2 KB) - added by YDARIO 12 years ago.
Patch file for chown/chgrp
patch-204b.txt (16.8 KB) - added by Yuri Dario 6 years ago.
patch-204t.txt (16.5 KB) - added by Yuri Dario 6 years ago.

Download all attachments as: .zip

Change History (12)

Changed 12 years ago by YDARIO

Attachment: chown-grp.txt added

Patch file for chown/chgrp

comment:1 Changed 12 years ago by YDARIO

I forgot: I implemented the missing functions into existing files to not modify the build environment.

comment:2 Changed 9 years ago by bird

Status: newassigned

comment:3 Changed 8 years ago by bird

Milestone: libc-0.6.5libc-0.7

comment:4 Changed 6 years ago by Yuri Dario

Milestone: libc-0.7libc-0.6.6

Changed 6 years ago by Yuri Dario

Attachment: patch-204b.txt added

comment:5 Changed 6 years ago by Yuri Dario

Owner: changed from bird to Yuri Dario
Status: assignedaccepted

Added reworked patches for branch and trunk.

Changed 6 years ago by Yuri Dario

Attachment: patch-204t.txt added

comment:6 Changed 6 years ago by bird

Need to split up some bits there… let me have a go at it.

comment:7 Changed 6 years ago by bird

r3813, r3814 and r3816 implements chown, fchown and lchown on trunk. It should also improve *chmod operation slightly.

comment:8 Changed 6 years ago by bird

r3817 and r3818 makes an attempt at backporting it to 0.6. Haven't set up the necessary bits to build 0.6 here, so I don't know whether it really builds nor works.

comment:9 Changed 6 years ago by bird

Resolution: fixed
Status: acceptedclosed
Note: See TracTickets for help on using tickets.