Opened 13 years ago

Closed 12 years ago

Last modified 12 years ago

#56 closed defect (fixed)

Driver load displays ALSA_VERSION as the Uniaud version

Reported by: Brendan Oakley Owned by: Yoda
Priority: normal Milestone:
Component: UNIAUD32 Version:
Severity: normal Keywords:


ALSA_VERSION, in include/version.h, should contain the version of ALSA being used for the build, but the driver displays this when it loads the driver, so it instead contains the version of Uniaud. The output needs to be changed to report PRODUCT_VERSION for the Uniaud version instead. Displaying of ALSA_VERSION is optional, but if it is to be displayed at all, the text needs to clearly indicate that it is the ALSA version, not the Uniaud version, and the Uniaud version is not to be omitted.

The place in the code for the ALSA version could instead be alsa-kernel/include/sound/version.h, because this is where ALSA keeps it, so a full update of the ALSA code would necessarily update it there.

Change History (4)

comment:1 in reply to:  description Changed 13 years ago by Brendan Oakley

I remembered wrong about alsa-kernel/include/sound/version.h. That is not where ALSA keeps it. Best to leave it set in include/version.h.

comment:2 Changed 12 years ago by Brendan Oakley

Owner: set to Yoda

comment:3 Changed 12 years ago by Brendan Oakley

Resolution: fixed
Status: newclosed

Fixed in changeset:235.

comment:4 Changed 12 years ago by Brendan Oakley

Sorry make that [234:236].

Note: See TracTickets for help on using tickets.