Opened 6 years ago

Closed 3 years ago

#229 closed defect (fixed)

smbprint inconsitently works

Reported by: abwillis Owned by: herwigb
Priority: Feedback Pending Milestone: GUI Tools 1.0.0
Component: Samba Server GUI Tools Version:
Keywords: Cc:

Description

I was finding problems with smbprint where it worked inconsistently. It did not work at all initially with smbprint.exe in the samba directory but worked for one printer (pdfwrite to create PDFs) but not for another (real printer) when I moved it to the spool directory. I found

-            ok = VRPrintFile( smbprintername, directory'\'spoolfile, , JobName )
+            ok = VRPrintFile( smbprintername, spoolfile, , JobName )

where directory is never set to anything. Removing the directory'/' and now both printers objects work even with smbprint in samba. I initially set directory=directory() - I had still had smbprint in the spool directory- and that will work as well but as the sysdelete function worked all along and it is without the directory information I decided to just remove it and it worked fine. I am adding a full diff file for context but it has some other changes I did for seeing more information (and changed one German word to English so that I knew what it was telling me).

Attachments (1)

smbprint.diff (1.3 KB) - added by abwillis 6 years ago.

Download all attachments as: .zip

Change History (7)

Changed 6 years ago by abwillis

comment:1 Changed 5 years ago by diver

  • Owner set to herwigb
  • Status changed from new to assigned

comment:2 Changed 5 years ago by diver

  • Priority changed from minor to Feedback Pending

@herwig any news?

comment:3 Changed 5 years ago by diver

  • Component changed from Unknown to Samba Client Command line utilities
  • Milestone set to Samba Client GUI (EVFSGUI) 2.1

comment:4 Changed 5 years ago by diver

  • Component changed from Samba Client Command line utilities to Samba Server GUI Tools
  • Milestone changed from Samba Client GUI (EVFSGUI) 2.1 to GUI Tools 1.0.0

comment:5 Changed 3 years ago by herwigb

There was an obvious typo (directory() versus directory). Fixed with changeset #981 and #982

comment:6 Changed 3 years ago by herwigb

  • Resolution set to fixed
  • Status changed from assigned to closed
Note: See TracTickets for help on using tickets.