Opened 8 years ago

Closed 8 years ago

#230 closed defect (fixed)

Avoid quoting of make variables/macros

Reported by: rudi Owned by:
Priority: minor Milestone: Qt 4.7
Component: qmake Version:
Severity: low Keywords:
Cc:

Description

In r909 quoting for "clean" targets was introduced. This creates a rule like this:

   -$(DEL_FILE) $(basename $(DESTDIR_TARGET)).map >nul 2>&1

I think, we should not quote file names, that are expanded by make.

Attachments (1)

gnumake.diff (457 bytes) - added by rudi 8 years ago.
Proposed patch

Download all attachments as: .zip

Change History (4)

Changed 8 years ago by rudi

Proposed patch

comment:1 Changed 8 years ago by rudi

  • Summary changed from Avoid quiting of make variables/macros to Avoid quoting of make variables/macros

comment:2 Changed 8 years ago by rudi

Oops, of course in the description I wanted to say:

    -$(DEL_FILE) "$(basename $(DESTDIR_TARGET)).map" >nul 2>&1

comment:3 Changed 8 years ago by dmik

  • Resolution set to fixed
  • Status changed from new to closed

Thanks. Fixed in r934.

Note: See TracTickets for help on using tickets.