Custom Query (80 matches)

There was some chatter on OS2World about updating the reported version of WinXP in Odin to SP3. I have run into an app that wanted that as well, though so far increasing the version only got rid of the message that I needed SP3 and did not fix the problem or I would just commit the change.

Index: version.cpp =================================================================== --- version.cpp (revision 21552) +++ version.cpp (working copy) @@ -88,14 +88,14 @@

2, 0, 0, 0

}

},

• Windows XP

+ Windows XP (SP3)

{

0x05005F03, /* Assuming DOS 5 like the other NT */ 0x0A280105, {

sizeof(OSVERSIONINFOA), 5, 1, 0xA28,

• VER_PLATFORM_WIN32_NT, "",
• 0, 0, 0, 0

+ VER_PLATFORM_WIN32_NT, "Service Pack 3", + 3, 0, 0, 0

}

}

};

When DosLoadModule? loads a DLL with the name having .DLL it will search for the file minus the DLL in the name. If the name does not have an extension or the extension is in lower case (.dll) then it will load. Odin has a number of obvious uses of DosLoadModule? with .DLL. There are some places where the file name is supplied by variable name... we may need to lowercase some variables if there are any reports of failures with libpathstrict.

Winrar 3.x worked very well under Odin but 4.x calls SHAutoComplete from shlwapi and it is not available. The following diff creates a stub which then allows Winrar 4.01 and 4.10b4 to work.

Index: url.c
===================================================================
--- url.c	(revision 21813)
+++ url.c	(working copy)
@@ -184,6 +184,15 @@
 
 
 /*************************************************************************
+ *      SHAutoComplete  	[SHLWAPI.@]
+ */
+HRESULT WINAPI SHAutoComplete(HWND hwndEdit, DWORD dwFlags)
+{
+  FIXME("SHAutoComplete stub\n");
+  return S_FALSE;
+}
+
+/*************************************************************************
  *        UrlCanonicalizeA     [SHLWAPI.@]
  *
  * Uses the W version to do job.
Index: shlwapi.def
===================================================================
--- shlwapi.def	(revision 21813)
+++ shlwapi.def	(working copy)
@@ -478,7 +478,7 @@
     PathUnquoteSpacesA     = _PathUnquoteSpacesA@4                @1157
     PathUnquoteSpacesW     = _PathUnquoteSpacesW@4                @1158
 
-;   SHAutoComplete         = _SHAutoComplete@8                    @1159
+    SHAutoComplete         = _SHAutoComplete@8                    @1159
   ; SHCopyKeyA             = _SHCopyKeyA@?                        @1160
   ; SHCopyKeyW             = _SHCopyKeyW@?                        @1161
     SHCreateShellPalette   = _SHCreateShellPalette@4              @1162

I have some other changes in my tree that I cannot remember why they are there, I think I had them to build msvcrt.dll and I do not want to mistakenly commit them and I want to make sure I don't have any other issues crop up from the stub before I commit anyhow.