WINXP version to SP3

[abwillis]

There was some chatter on OS2World about updating the reported version of WinXP in Odin to SP3. I have run into an app that wanted that as well, though so far increasing the version only got rid of the message that I needed SP3 and did not fix the problem or I would just commit the change.

Index: version.cpp =================================================================== --- version.cpp (revision 21552) +++ version.cpp (working copy) @@ -88,14 +88,14 @@

2, 0, 0, 0

}

},

• Windows XP

+ Windows XP (SP3)

{

0x05005F03, /* Assuming DOS 5 like the other NT */ 0x0A280105, {

sizeof(OSVERSIONINFOA), 5, 1, 0xA28,

• VER_PLATFORM_WIN32_NT, "",
• 0, 0, 0, 0

+ VER_PLATFORM_WIN32_NT, "Service Pack 3", + 3, 0, 0, 0

}

}

};

[Silvan Scherrer]

higher the Win version to XP SP3 could make sense anyway.

[Silvan Scherrer]

we should decide on that for the next odin version

[dmik]

Well, we may do that of course but I'm not sure if our current Odin implements all additions SP3 should have.

But we can still do it. Since right now there are still some unimplemented functions that must be present in NT strictly speaking.

[abwillis]

It hasn't seemed to hurt anything that I can tell but we could add it as an option instead of a replacement as I have currently so that we could choose XP or XP sp3. I don't know that it would be helpful for that or not and would require quite a bit more to do that.

[dmik]

I think that we should provide a parameter in ODIN.INI that sets the default Windows version for the Odin runtime and add command line switches for PE/PEC to override it for a specific application. For cases when Odin is used from OS/2 applications (like Java or Mozilla), there is an OdinSetVersion API (each application may hard code a particular version and also provide its own ways of configure if needed).

The first two things are easily doable. I won't mind if you implement them -)

[dmik]

Applied the patch (with important corrections from Silvan) in r22030. Made XP SP3 the default Windows version in r22031. Closing this ticket.

I'm ready for the release and will do it either later today or tomorrow morning.