Opened 3 years ago

Closed 3 years ago

#318 closed enhancement (fixed)

suspicious file open dialog option

Reported by: rbri Owned by: gyoung
Priority: major Milestone:
Component: UI Version: 1.4.0
Keywords: Cc:

Description

Stumbled on the new option 'Toggle no thumbnail creation'. As far as i can see, this is a checkbox. Usually the text for checkboxes have no 'toggle' part. The text describes the behavior used when the box is checked. My expectation is more like 'Create thumbnails' and the initial checkbox state depends on the option setting.

But maybe i'm wrong....

Change History (7)

comment:1 Changed 3 years ago by lewisr

The setting to suppress creation of thumbnails is in the Settings dialog.

When unchecked (the shipping default), thumbnails are created as expected (except for encrypted PDFs, where no thumbnails are created). The toggle in the Open File dialog reverses the default for the selected file.

Likewise, when thumbnail creation has been suppressed in the Settings dialog, checking this box will force the creation of a thumbnail (except for an encrypted PDF, where this does nothing).

What you are suggesting, then, Ronald, is that we reflect the current state of the checkbox as set in the Settings dialog. This makes sense, if we then adjust the string accordingly.

comment:2 Changed 3 years ago by gyoung

Lewis' description is correct regarding the function. It would be very easy to label it make thumbnail and have it checked by default (takes an !) if you think that makes the function clearer. In all cases each time you reopen the dialog this has reverted to match the settings notebook setting.

comment:3 Changed 3 years ago by rbri

Have done a quick look at the latest rc.

I like to suggest:

  • In all cases each time you open the dialog the checkbox check state matches the choosen general setting
  • the checkbox is labled 'create thumbnail on open'
  • the checkbox should be placed at the right of the cancel button (because this is related to the open action and not to the preview as the current placement suggests).
  • make the preview the same height as the folder and file list boxes and move the help button to the right; take care the right border of the help button matches the right border of the preview control
  • and regarding the options dialog, please move the checkbox to the right; the left border of the checkbox should match the left border of the entry fields

Just my two cents

BTW: great progress

comment:4 Changed 3 years ago by lewisr

Thanks, Ronald. Your input here is greatly appreciated.

To confirm, CUA '91 recommends:

Use a check box only if a user will clearly understand the meaning of the choice when it is selected or not selected. For example, use a check box for a choice labeled Locked. A user can clearly understand that when the check box is selected, the associated object is locked, and when the check box is not selected, the associated object is not locked. Otherwise, use a control that clearly identifies the two choices, such as two radio buttons.

As for the positioning of the checkbox in the Settings dialog, I understand your point. Keep the checkbox to the left of the text but move the entire option over so that the laft side of the box is aligned with the left side of the input field above, as in:

+-------------------------------------------------------+
|                        +--------------------------+-+ |
| Default Page Layout    | Single page              |V| |
|                        +--------------------------+-+ |
|                        +--------------------------+-+ |
| Default Zoom           | Fit width                |V| |
|                        +--------------------------+-+ |
|                        ++                             |
|                        ++  Create Thumbnail on open   |
+-------------------------------------------------------+

This is a re-working of ticket:267#comment:9. Then, for the Open File dialog, re-working my original proposal in ticket:267#comment:9 this would be:

+---------------------------------------------------------------------------------------+
|           +-----------------------------------------------------------------+         |
| Filename  |                                                                 |         |
|           +-----------------------------------------------------------------+         |
|           +---------------+-+              +------------------------------+-+         |
| Drive     |C: [OS2BOOT]   |V|  File Type   |<All supported types>         |V|         |
|           +---------------+-+              +------------------------------+-+         |
|                                                                                       |
| Directory                   File                                                      |
|+-----------------------+-+  +-------------------------+  +-------------------------+  |
||                       |^|  |                       |^|  |                         |  |
||                       |-|  |                       |-|  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |  No preview available   |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       | |  |                       | |  |                         |  |
||                       |-|  |                       |-|  |                         |  |
||                       |v|  |                       |v|  |                         |  |
|+-----------------------+-+  +-------------------------+  |                         |  |
||<|                     |>|  |<|                     |>|  |                         |  |
|+-----------------------+-+  +-------------------------+  +-------------------------+  |
|                                                                                       |
|+----------+ +----------+  ++                                            +----------+  |
||    OK    | |  Cancel  |  ++  Create Thumbnail on open                  |   Help   |  |
|+----------+ +----------+                                                +----------+  |
+---------------------------------------------------------------------------------------+

The default state of the checkbox always mirrors the Settings dialog choice.

I think these work better. Is this what you had in mind?

comment:5 Changed 3 years ago by rbri

Exactly!

comment:6 Changed 3 years ago by gyoung

  • Owner set to gyoung
  • Status changed from new to assigned

comment:7 Changed 3 years ago by gyoung

  • Resolution set to fixed
  • Status changed from assigned to closed

CS [580] Modified dialogs as pictured by Lewis above.

Note: See TracTickets for help on using tickets.