Custom Query (245 matches)

weakld sometimes (wonder if symbol hashing is required) outputs more than one alias for the same weak symbol. This naturally causes some serious screwup in the binary... ilink gives this warning when it sees the duplicate alias: R:\TMP\wk101643e4c0f21cf468.obj(wk0.obj) : warning LNK4080: changing substitute name for alias "snip" from "snip" to "snip".

ld crashes when map file name differs from module name, because of wrong memory allocation.

Index: src/ld/ld.c
===================================================================
--- src/ld/ld.c	(revision 2508)
+++ src/ld/ld.c	(working copy)
@@ -3984,7 +3984,7 @@
 	{
 	  if (map_filename == NULL)
 	    {
-	      freeav[j++] = map_filename = ALLOCA (strlen (output_filename) + 5);
+	      freeav[j++] = map_filename = ALLOCA (strlen (exe_filename) + 5);
               strcpy (map_filename, exe_filename);
 	      _remext (map_filename);
 	      strcat (map_filename, ".map");

Symbols longer than 127 bytes are truncated, code removed appear bad written code.

Index: src/emxbind/export.c
===================================================================
--- src/emxbind/export.c	(revision 2508)
+++ src/emxbind/export.c	(working copy)
@@ -75,10 +79,7 @@
   word ord16;
 
   name_len = strlen (name);
-  if (name_len >= 128)
-    name_len = 127;
-  else
-    blen = (byte)name_len;
+  blen = (byte)name_len;
   ord16 = (word)ord;
   put_grow (table, &blen, 1);
   put_grow (table, name, name_len);
Index: src/emxbind/fixup.c
===================================================================
--- src/emxbind/fixup.c	(revision 2508)
+++ src/emxbind/fixup.c	(working copy)
@@ -284,8 +284,6 @@
   byte blen;
 
   name_len = strlen (name);
-  if (name_len >= 128)
-    name_len = 127;
   i = 0;
   while (i < procs.len)
     {