Custom Query (245 matches)

In write_output(), map file name overwrites memory because of wrong allocation. At line 3985, correct code is

if (map_filename == NULL)

{

freeav[j++] = map_filename = ALLOCA (strlen (exe_filename) + 5); strcpy (map_filename, exe_filename); _remext (map_filename); strcat (map_filename, ".map");

}

The module name used by emxbind when building dynamic libraries is not read from .def file: it is built from output name, but this prevents dotted names for the dll.

This change to emxbind.c allows using LIBRARY name from def file:

case _MD_LIBRARY:

/* Create a DLL. Save the initialization and termination

policies after choosing default values for unspecified values. */

if (stmt->library.name[0] != 0)

module_name = xstrdup (stmt->library.name);

ld crashes when map file name differs from module name, because of wrong memory allocation.

Index: src/ld/ld.c
===================================================================
--- src/ld/ld.c	(revision 2508)
+++ src/ld/ld.c	(working copy)
@@ -3984,7 +3984,7 @@
 	{
 	  if (map_filename == NULL)
 	    {
-	      freeav[j++] = map_filename = ALLOCA (strlen (output_filename) + 5);
+	      freeav[j++] = map_filename = ALLOCA (strlen (exe_filename) + 5);
               strcpy (map_filename, exe_filename);
 	      _remext (map_filename);
 	      strcat (map_filename, ".map");