Custom Query (245 matches)

dirOpen isn't initializing the fInUnixTree member, and a fchdir operation may then load garbage into the global flag and screw things up really badly.

when arg_init() is called, the temporary files is not deleted, so at program exit only the last temporary files is effectively erased.

Index: emxomfld.c
===================================================================
--- emxomfld.c	(revision 2508)
+++ emxomfld.c	(working copy)
@@ -1160,7 +1163,11 @@
 
 static void arg_init (int rsp)
 {
-  response_fname[0] = '\0';
+  if (response_fname[0] != '\0')
+    {
+      remove (response_fname);
+      response_fname[0] = '\0';
+    }
   command_line[0] = '\0';
   line_len = 0;
   response_flag = rsp;

When the output file name doesn't include the extension (this is not required for omf linkers), the map file name space allocation is shorter than needed, so a memory overwriting occurs.

Index: emxomfld.c
===================================================================
--- emxomfld.c	(revision 2508)
+++ emxomfld.c	(working copy)
@@ -1657,8 +1670,13 @@
     map_fname = "nul";
   else if (map_fname == NULL)
     {
-      t = xstrdup (output_fname);
+      //yd output file name can be without extension, need to alloc enough space
+      t = xmalloc (strlen (output_fname) + 1 + 4);
+      strcpy (t, output_fname);
       _remext (t);