Opened 2 years ago

Closed 2 years ago

#54 closed defect (fixed)

DDK files in FAT32 SVN repo

Reported by: ecsnl Owned by:
Priority: blocker Milestone: Future
Component: IFS Version:
Severity: highest Keywords:
Cc: andib, stevenhl

Description

I always wonder why files that are part of another set of files need to included in other projects such as these: These are from \ddk\base\h

src\include\devclass.h src\include\devcmd.h src\include\devhdr.h src\include\devhelp.h src\include\dhcalls.h src\include\dskinit.h src\include\fsd.h src\include\fsh.h src\include\infoseg.h src\include\iorb.h src\include\reqpkt.h src\include\sas.h src\include\strat2.h

This is not a full list. There are others pulled from other subdirectorieis of the DDK sources.

Somebody send me that list. Also the inclusion of these files violates the IBM DDK license.

Change History (9)

comment:1 Changed 2 years ago by ecsnl

So they need to removed where possible from SVN.

comment:2 Changed 2 years ago by valerius

Will be removed when we'll make our own headers.

This is not a full list. There are others pulled from other subdirectorieis of the DDK sources.

there are no others

comment:3 Changed 2 years ago by valerius

PS: Some ddk files were included in fat32.ifs sources back in the version 0.9.13. Nobody complained so far. I can create my own headers, but I doubt it is really needed. IBM doesn't care, at least. Why should you care?

comment:4 Changed 2 years ago by ecsnl

Its not a good development practice to include DDK header files into your source tree. You keep it in your development environment and include them to compile the code. Why put in dupe files.

What matters is that the DDK license applies to the files. IBM never modified the license on the DDK.

What does UNIAUD list: http://trac.netlabs.org/uniaud/wiki#Buildingthedrivers http://trac.netlabs.org/ahci (see building section)

comment:5 Changed 2 years ago by valerius

I don't want to be dependent on DDK being installed. The same is done by ramfs sources.

comment:6 Changed 2 years ago by andib

  • Cc andib added

comment:7 Changed 2 years ago by stevenhl

  • Cc stevenhl added

comment:8 Changed 2 years ago by valerius

With r302, IBM's headers are changed to our own ones, so closing this ticket.

PS: Let's IBM copyright defenders choke.

PPS: As it were discussed with experts on #os2russian, they violate nothing, but I don't want to dispute anymore.

comment:9 Changed 2 years ago by valerius

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.