Opened 10 years ago

Closed 10 years ago

Last modified 7 years ago

#478 closed defect (fixed)

AcpiExecSingleCPU: Spinlock is not released

Reported by: Lars Erdmann Owned by: Lars Erdmann
Priority: major Milestone:
Component: ACPI PSD Version: 3.17
Keywords: Cc:

Description

src\acpi\psd\acpicpu.c, routine "AcpiExecSingleCPU":

around line: 802
if (ExeFlag? & SMPEXEC_IPITIME), a CPU spinlock is aquired, then the user function executed but the CPU spinlock is not released thereafter.
I believe the code should be corrected to read:

    if (ExeFlag & SMPEXEC_IPITIME)
    {
        while ( __lxchg((volatile int*)&CPULock, 1) );     // Wait if we are here
        CPUMask &= (~(1 << pPSDPLMA->procnum)); // Clear bit, this CPU was execute
        Status = Execute ( (void *)Context );                 // call function
        __lxchg((volatile int*)&CPULock, 0) ;                // give way to next CPU -> ADD THIS !
        return Status;
    }

Change History (5)

comment:1 Changed 10 years ago by Lars Erdmann

Milestone: Release version 3.17eCS 2.x
Version: 3.163.17

comment:2 Changed 10 years ago by Lars Erdmann

Owner: changed from eco to Lars Erdmann

comment:3 Changed 10 years ago by Lars Erdmann

Is now incorporated into trunk.

comment:4 Changed 10 years ago by Lars Erdmann

Resolution: fixed
Status: newclosed

comment:5 Changed 7 years ago by David Azarewicz

Milestone: eCS 2.x

Milestone eCS 2.x deleted

Note: See TracTickets for help on using tickets.