#73 closed defect (fixed)
login slow with new os2_randget() in os2ea.c
| Reported by: | Herwig Bauernfeind | Owned by: | Herwig Bauernfeind |
|---|---|---|---|
| Priority: | major | Milestone: | Samba Server for eCS (OS/2) 1.0.1 |
| Component: | Samba Server | Version: | 3.0.33 |
| Keywords: | login slow os2_randget() | Cc: | herwig.bauernfeind@… |
Description
The new os2_randget() function in os2ea.c slows down login (and possibly other operations) considerably.
For each login the randbyte_hrtimer() subroutine is executed exactly 129 times, a DosSleep(5) occurs for every execution, this sums up to a delay of almost 0,7 secs per login.
My suggestion as a fix would be to remove the randbyte_hrtimer() portion completely (reducing DosSleep(5) to DosSleep(1) is better, but still slow) as randbyte_hrtimer() is only one of 3 components and the remaining randbyte_sysinfo() and randbyte_perf() still provide more "randomness" than what was available before Changeset #160 and the resulting login speed is perfectly acceptable this way.
An appropriate unified dif is attached.
Attachments (1)
Change History (6)
by , 16 years ago
comment:1 by , 16 years ago
| Owner: | changed from to |
|---|
comment:2 by , 16 years ago
| Resolution: | → fixed |
|---|---|
| Status: | new → closed |
comment:5 by , 16 years ago
| Version: | → 3.0.33 |
|---|
Note:
See TracTickets
for help on using tickets.
os2_randget() with randbyte_hrtimer() removed