Arora drawing problem while dragging

[rudi]

The Arora browser allows a bookmark to be dragged out of the "History" menu using the left mouse button. On OS/2 this will cause a screen update error. This happens in in both DIVE and GPI modes.

I noticed an interresting difference in behaviour between OS/2 and Windows: While in Windows the menu stays open until the item is dropped, in OS/2 it closes immediately when the drag begins. It looks like this is part of the problem...

[Dmitry A. Kuminov]

Can you please provide an Arora source drop that shows this behavior?

[rudi]

You can grab the source here:

​http://telefon.s-t.de/rudi/aurora_0_10_2.zip

Just run qmake and make [Debug/Release]. Note: there is a fix for a little sloppyness of the original source in src\network\networkaccessmanager.h, which is unneccessary, when compiled with SSL support...

[Dmitry A. Kuminov]

Confirm the update error. Regarding the differences with the Windows behavior. Interesting what is the expected one -- for me, closing the menu right after dragging begins sounds more reasonable since you may want to drop it somewhere under the menu, for example.

Anyway, will look at it little bit later.

[rudi]

you may want to drop it somewhere under the menu, for example.

I think the idea is to drop it on the menu (to change item order).

[Dmitry A. Kuminov]

I don't think so. At least, dragging it on Windows doesn't cause the menu items to rearrange.

[rudi]

dragging it on Windows doesn't cause the menu items to rearrange

Strange, here it does. Even though it's broken since it sometimes/often leads to duplication of menu items.

[Dmitry A. Kuminov]

Yes, I got this broken behavior on Windows here. It looks like the items in the bookmarks menu replace the ones underneath instead of being inserted in the middle when you drag and drop them.

Back to the topic. All popup menus are dismissed once we enter DrgDrag(). I will check the drag message handlers to find who's responsible. I hope it's not some internal PM behavior because we're in trouble in this case.

[Dmitry A. Kuminov]

The problem is fixed in r785. Now we get the behavior identical to the Windows version.

[Dmitry A. Kuminov]

Fixed one more DnD repaint screen corruption bug in r786 that could be sometimes seen when dragging the bookmark item out of the popup menu in DIVE mode.