Opened 14 years ago

Closed 14 years ago

#167 closed enhancement (fixed)

Add SSL support

Reported by: rudi Owned by:
Priority: major Milestone: Qt 4.6.3
Component: QtNetwork Version: 4.6.2
Severity: medium Keywords:
Cc:

Description

The Arora web browser would benefit from SSL support. I gave it a quick try and it appears to be not a too big issue. Using openssl-1.0.0a-os2knix-20100603-dev.zip and openssl-1.0.0a-os2knix-20100603-runtime.zip from Hobbes, Arora could successfully login to eBay.

Find patches for run-time loading of OpenSSL attached. It needs to be discussed, if we should support the 0.9.x series of OpenSSL and/or if we should provide some means for the end user to specify the names of the SSL DLLs. Also configure.cmd needs to be changed...

Attachments (1)

ssl_support.zip (1.6 KB ) - added by rudi 14 years ago.

Download all attachments as: .zip

Change History (11)

by rudi, 14 years ago

Attachment: ssl_support.zip added

comment:1 by Silvan Scherrer, 14 years ago

i didn't look to closely to the openssl 1.0. but with 0.9.8 the os2_rand() functions need to be redone. they will probably not work on quadcore systems as i think it was done the same as in samba.

comment:2 by rudi, 14 years ago

Since we just dyna-load the OpenSSL DLLs, we have to rely on the porter of these to do the right thing.

BTW, there also is the possibility to link OpenSSL directly into QtNetwork, but I vote against doing so. Not only that it would make QtNetwork unnecessarily big, there might also be some legal issues with that...

comment:3 by Silvan Scherrer, 14 years ago

in my opinion we should have some kind of configurable dll names. as i find it not very good to change the source everytime someone decides to change the dll name.
and i guess we should contact the porter and ask if he can change the dll names. as in my opinion the k prefix is useless. i know he produces emx and libc dll. but isn't the libc path the defacto standard now :) i'm trying to figure out his mal address. if anyone as it it would help, as on the web i could not find it till now.

comment:4 by Silvan Scherrer, 14 years ago

Priority: minormajor
Severity: lowmedium

comment:5 by Silvan Scherrer, 14 years ago

on http://ebisa.hp.infoseek.co.jp/os2/index.htm are the newest runtime for openssl 1.0 and openssl 0.9.8
i also vote for 1.0 runtime.

and the smp issue seems fixed, as he changed some stuff in the rand() function.

comment:6 by Dmitry A. Kuminov, 14 years ago

Milestone: Qt EnhancedQt 4.6.3

Will try to do that for 4.6.3.

comment:7 by rudi, 14 years ago

I just learned, that the MySQL and PosgreSQL plugins need to be linked against the OpenSSL libraries as well. We should ensure, that all Qt components use the same version of these libs. Especially, if we decide to ship binary versions of these plugins.

comment:8 by Silvan Scherrer, 14 years ago

please go with the shared (dll) way, as we need openssl in many different areas. and link statically doesn't make sense. and shared has the advantage of exchanging dll easy. even the current port still crashes on systems with 2 and more cores. i have already a fixed openssl 1.0 port. of course with the same name kssl10.dll and kcrypt10.dll. i try to contact the original porter and give him my diff.
and i also think we should use latest, as using older is never good.

comment:9 by Dmitry A. Kuminov, 14 years ago

This is the new URL for the OpenSSL builds: http://bauxite.sakura.ne.jp/software/os2/

comment:10 by Dmitry A. Kuminov, 14 years ago

Resolution: fixed
Status: newclosed

I added OpenSSL support in r788. Note that we search for both standard names (ssl10, crypto10) and the ones with the k* prefix -- to make the build compatible with the k* libs for the time being. (The non-k versions are in RPM that isn't really deployed yet).

Checked a couple of https:// sites in Arora, they seem to work now.

Note: See TracTickets for help on using tickets.