setmode() behavior

[KO Myung-Hun]

Hi/2.

setmode() works on every file handles, unconditionally. But it would be better to set the handles to text mode if they are consoles.

And, I think, setting consoles to binary mode is meaningless.

In practice, MinGW beahves like this.

[bird]

What on earth are you babbling about here? setmode() in trunk/libc/src/libc/io/pc_setmode.c​ works on individual file handles.

[KO Myung-Hun]

What I meant is simple. Check if a file handle is for a console before setting its mode. If a console, do not set to binary mode(O_BINARY). Set to O_TEXT always. That is, I want for kLIBC to include the equivalent codes to the following,

#define setmode(h, m) (setmode)(h, isatty(h) ? O_TEXT : ( m ))