#132 closed enhancement (fixed)
Please add a high-mem safe wrapper for DosQueryAppType()
Reported by: | guest | Owned by: | bird |
---|---|---|---|
Priority: | normal | Milestone: | libc-0.6.3 |
Component: | libc | Version: | 0.6 |
Severity: | normal | Keywords: | WinUpper DosQueryAppType |
Cc: | mozilla@… |
Description
DosQueryAppType() is not listed in the high-mem supporting APIs and indeed it acts weird (returncode=87 and appType=0 whatever the real appType is) when being passed a char* as first argument that is located above 512MB. So it would be great, if it a SafeDosQueryAppType() wrapper could be written and then add it to os2safe.h.
Attachments (1)
Change History (5)
comment:1 by , 18 years ago
by , 17 years ago
Attachment: | add_SafeDosQueryAppType.diff added |
---|
Patch (1st try) to implement SafeDosQueryAppType
comment:2 by , 17 years ago
Hmm, weird. Why does Trac only display the first part of the diff?
Anyway, again without even trying to compile libc (don't have time to even try) the diff I just attached is a first try to add a safe wrapper for DosQueryAppType(). Don't understand what the SAFE_DOS_FAILURE() is about but copied that from other wrappers. I guess the PSCZ macros also work for PSZs...
comment:3 by , 17 years ago
Resolution: | → fixed |
---|---|
Status: | new → closed |
(In [3387]) Added SafeDosQueryAppType and SafeWinUpper (both untested). Fixes #132.
comment:4 by , 17 years ago
Keywords: | WinUpper DosQueryAppType added |
---|---|
Milestone: | → libc-0.6.3 |
Version: | → 0.6 |
Not sure if you would rather have a separate ticket for it but as a place to keep track of it, WinUpper also was an unsafe call.