Opened 16 years ago

Closed 16 years ago

Last modified 16 years ago

#66 closed defect (fixed)

unneeded inclusion of sys/acl.h

Reported by: Alessio Cassibba (X-Drum) Owned by: bird
Priority: minor Milestone: 0.1.5
Component: kmk Version: 0.1.4
Keywords: Cc:

Description

kmk needs sys/acl.h to build (included in: src/kmk/kmkbuiltin/mv.c) but actually acl functionality is only used in fastcopy().

In addition fastcopy is only compiled when CROSS_DEVICE_MOVE is defined.

Initial patch credit goes to Christian Authmann (comment #2): ​http://bugs.gentoo.org/show_bug.cgi?id=236949

Attachments (1)

kbuild-fix-acl-include.patch​ (575 bytes ) - added by Alessio Cassibba (X-Drum) 16 years ago.
Reworked Christian Authmann 's patch

Download all attachments as: .zip

Change History (3)

by Alessio Cassibba (X-Drum), 16 years ago

Attachment: kbuild-fix-acl-include.patch​ added

Reworked Christian Authmann 's patch

comment:1 by bird, 16 years ago

Resolution: → fixed
Status: new → closed

(In [2142]) mv.c: avoid including sys/acl.h. Fixes #66.

comment:2 by bird, 16 years ago

(In [2251]) debian/control: drop libacl1-dev dependency. References #66.

Note: See TracTickets for help on using tickets.