Opened 8 years ago

Closed 7 years ago

Last modified 7 years ago

#70 closed task (fixed)

MakeBackups and KeepBackups in m_plain.fte appear to do the same thing

Reported by: Gregg Young Owned by: Gregg Young
Priority: minor Milestone: Release_1.1
Component: eFTE core Version: Release_1.0
Keywords: Cc: Alfredo Fernández Díaz

Description


Change History (4)

comment:1 by Gregg Young, 7 years ago

Owner: set to Gregg Young
Status: newaccepted

MakeBackups cause the creation of a backup file e_loadsave.cpp ~527. KeepBackups along with a couple of other checks may delete the back file. The file is used to try to recover a failed save.

Last edited 7 years ago by Gregg Young (previous) (diff)

comment:2 by Gregg Young, 7 years ago

Resolution: fixed
Status: acceptedclosed
Type: defecttask

Documented how this works. CS [169]

comment:3 by Alfredo Fernández Díaz, 7 years ago

The documentation change in CS 169 is how I assumed it works, but let me play Devil's advocate here...

Binary MakeBackups and KeepBackups make up a total of 4 combinations: M0K0, M1K0, M1K1
but to me it looks like M = 0, K = 1 doesn't really make sense.

Perhaps a ternary option would be better (Backups = 0 [don't], 1 [make, replace original file, delete], 2 [keep])? What do you think?

We already have a ternary WordWrap option that has its value cycled on 'toggle' just like that.

comment:4 by Alfredo Fernández Díaz, 7 years ago

Cc: Alfredo Fernández Díaz added
Note: See TracTickets for help on using tickets.