History is not consistently saved (perhaps not saved when close button is used)

[Gregg Young]

It works as expected using exit but isn't saved when the close button is used.

[Alfredo Fernández Díaz]

I just tried and history seems to be saved here -- this should affect only the PM version anyway (no toolbar in VIO; do other platforms have toolbars?).

Relevant changes to g_pm.cpp are mentioned in ​Changeset 174, and the code looks kosher to me. I will close this as 'fixed' in a week if no more comments are made.

[Gregg Young]

CS [174}

[Gregg Young]

Note this fix changed a return code that could affect other platforms. egui.cpp int EGUI::ExitEditor(EView * View) the return was changed from 1 to 0 (line ~587) to make this work.

[Alfredo Fernández Díaz]

I didn't go into the changeset deep enough to notice that--it still may take me a while to wrap my head around many parts anyway.

Isn't egui.cpp linked into the VIO version as well? If so, that might give us a pointer to what else we should be testing before forgetting about this.