Custom Query (8 matches)

Hello

On machines with higher resolutions like 1,920 x 1,080, I usually increase the size of XCenter to a more confortable size. But there is the issue that icons size on any widget remains the same.

I was wondering if something can be done so the user can increase the size of the icons of XCenter.

Regards

Version 1.0.16:

Refreshing an open folder multiple times will lead to nested invocations of "wpRefresh" that compete with each other (and starting multiple refresh threads).

I suggest this change, so that "wpRefresh" will not be called nested (src\classes\xfldr.c):

SOM_Scope BOOL  SOMLINK xf_wpRefresh(XFolder *somSelf,
                                     ULONG ulView,
                                     PVOID pReserved)
{
    BOOL        rc;
    ULONG fFlags;

    // XFolderData *somThis = XFolderGetData(somSelf);
    XFolderMethodDebug("XFolder","xf_wpRefresh");

    fFlags = _wpQueryFldrFlags(somSelf);

    if (fFlags & (FOI_REFRESHINPROGRESS | FOI_POPULATEINPROGRESS))
    {
       return FALSE;
    }

   _wpModifyFldrFlags(somSelf, FOI_REFRESHINPROGRESS,FOI_REFRESHINPROGRESS);

    rc = XFolder_parent_WPFolder_wpRefresh(somSelf, ulView, pReserved);

    fdrForEachOpenInstanceView(somSelf,
                               stb_UpdateCallback,
                               2);           // update

    xthrPostWorkerMsg(WOM_REFRESHFOLDERVIEWS,
                      (MPARAM)somSelf,
                      (MPARAM)FDRUPDATE_TITLE);

   _wpModifyFldrFlags(somSelf, FOI_REFRESHINPROGRESS,0);

    return rc;
}

It might also be better to move the "_wpModifyFldrFlags(somSelf, FOI_REFRESHINPROGRESS,0);" call to the window function invoked by "xthrPostWorkerMsg" (src\filesys\xthreads.c):

MRESULT EXPENTRY fnwpWorkerObject(HWND hwndObject, ULONG msg, MPARAM 
mp1, MPARAM mp2)
{
    MRESULT mrc = NULL;

    switch (msg)
    {
...
        case WOM_REFRESHFOLDERVIEWS:
        {
            XFolder     *pFolder = NULL,
                        *pCalling = (XFolder*)(mp1);

            for ( pFolder = _wpclsQueryOpenFolders(_WPFolder, NULL, QC_FIRST, FALSE);
                  pFolder;
                  pFolder = _wpclsQueryOpenFolders(_WPFolder, pFolder, QC_NEXT, FALSE))
            {
                if (    (wpshCheckObject(pFolder))
                     && (_somIsA(pFolder, _WPFolder))
                   )
                {
                    if (    (!pCalling)
                         || (wpshResidesBelow(pFolder, pCalling))
                       )
                    {
                        // folder applies:
                        fdrUpdateAllFrameWindows(pFolder, (ULONG)mp2);
                    }
                }
            }
            if (pCalling)
            {
               _wpModifyFolderFlags(pCalling,FOI_REFRESHINPROGRESS,0);
            }
        }
        break;
...

Version 1.0.16:

The "DiskFreeCondensed" widget always forgets its size when it is resized. The Widget configuration properly remembers the size in its WIDTH parameter but apparently, the parameter is not applied when the widget is drawn. It's always drawn with a fairly small default width.

It used to work ok with Version 1.0.15.