Opened 12 years ago

Closed 12 years ago

Last modified 11 years ago

#73 closed defect (fixed)

login slow with new os2_randget() in os2ea.c

Reported by: Herwig Bauernfeind Owned by: Herwig Bauernfeind
Priority: major Milestone: Samba Server for eCS (OS/2) 1.0.1
Component: Samba Server Version: 3.0.33
Keywords: login slow os2_randget() Cc: herwig.bauernfeind@…


The new os2_randget() function in os2ea.c slows down login (and possibly other operations) considerably.

For each login the randbyte_hrtimer() subroutine is executed exactly 129 times, a DosSleep?(5) occurs for every execution, this sums up to a delay of almost 0,7 secs per login.

My suggestion as a fix would be to remove the randbyte_hrtimer() portion completely (reducing DosSleep?(5) to DosSleep?(1) is better, but still slow) as randbyte_hrtimer() is only one of 3 components and the remaining randbyte_sysinfo() and randbyte_perf() still provide more "randomness" than what was available before Changeset #160 and the resulting login speed is perfectly acceptable this way.

An appropriate unified dif is attached.

Attachments (1) (757 bytes) - added by Herwig Bauernfeind 12 years ago.
os2_randget() with randbyte_hrtimer() removed

Download all attachments as: .zip

Change History (6)

Changed 12 years ago by Herwig Bauernfeind

Attachment: added

os2_randget() with randbyte_hrtimer() removed

comment:1 Changed 12 years ago by Herwig Bauernfeind

Owner: changed from Paul Smedley to Herwig Bauernfeind

comment:2 Changed 12 years ago by Herwig Bauernfeind

Resolution: fixed
Status: newclosed

comment:3 Changed 12 years ago by Herwig Bauernfeind

fixed with changeset #162

comment:5 Changed 11 years ago by Herwig Bauernfeind

Version: 3.0.33
Note: See TracTickets for help on using tickets.