Opened 12 years ago

Closed 11 years ago

Last modified 10 years ago

#58 closed defect (fixed)

ndpsmb.dll does not distinguish between printer and directory shares

Reported by: herwigb Owned by:
Priority: critical Milestone: Netdrive plugin 1.0
Component: Samba Client Plugin Version:
Keywords: ndpsmb printer share Cc:

Description

The Samba Client ndpsmb.dll does not distinguish between printer and directory shares.

The result of this that both eVFSGUI (eCS Bugtracker #1996) and NetDrive? happily mount printers as directories.

The problem is even documented in ndpsmb.c in line 860 and following, where the Samba ressource type is explicitly ignored.

Change History (3)

comment:1 Changed 11 years ago by ydario

(changeset:128) Instead of default type, we force dev_type to be IPC or A:, so connection to printers fails with rc=7. The error is reported back as ACCESS_DENIED.

This is detected only at connection time, not at mount time.

comment:2 Changed 11 years ago by ydario

  • Resolution set to fixed
  • Status changed from new to closed

(changeset:129) the printers are stripped in server shares enumeration.

(changeset:130) now return error code has more sense.

(changeset:131) check for resources also at mount time: to avoid slowing ndctl startup, the check is done only if current thread is not the main thread(1). Mounting a wrong share from nd/ndpm is checked immediately, so next drop of control panel gui will allow users to edit parameters in dialog and try again.

comment:3 Changed 10 years ago by herwigb

  • Milestone set to Netdrive SMB Client plugin 1.0
Note: See TracTickets for help on using tickets.