Changeset 775

Timestamp:

Aug 4, 2010, 1:28:23 PM (15 years ago)

Author:

Dmitry A. Kuminov

Message:

gui: Fixed a possible crash and an endless PM event loop recursion when re-parenting widgets in DIVE mode. This could be seen when dragging a toolbar out of the dock widget, dragging it back then closing the application (crash) or attempting to drag the toolbar out again (endless recursion).

Location:

trunk/src/gui

Files:

• kernel/qwidget_pm.cpp (modified) (3 diffs)
• painting/qwindowsurface_pm.cpp (modified) (10 diffs)

trunk/src/gui/kernel/qwidget_pm.cpp ¶

@@ -1389 +1389 @@
             qApp->d_func()->closePopup(this);
         if (destroyWindow && !(windowType() == Qt::Desktop) &&
-            internalWinId() != NULLHANDLE) {
-            HWND id = internalWinId();
-            if (isWindow() && !(windowType() == Qt::Popup)) {
-                // extra data including extra->topextra has been already
-                // deleted at this point by deleteExtra() and therefore
-                // calling frameWinId() is useless -- it will return the
-                // client window handle. Use WinQueryWindow() instead.
-                id = WinQueryWindow(id, QW_PARENT);
-                Q_ASSERT(id != NULLHANDLE);
-            }
+            d->frameWinId() != NULLHANDLE) {
+            // make sure the backing store is deleted before destroying HWND --
+            // QPMDiveWindowSurface depends on that
+            delete d->topData()->backingStore;
+            d->topData()->backingStore = 0;
+            // now destroy HWND
+            HWND id = d->frameWinId();
 #if defined(QT_DEBUGWINCREATEDESTROY)
             qDebug() << "|Destroying window" << this
@@ -1472 +1469 @@
     }
 
-    if ((q->windowType() == Qt::Desktop))
-        old_fid = NULLHANDLE;
+    if (old_fid != NULLHANDLE && q->windowType() != Qt::Desktop) {
+        // make sure the backing store is deleted before destroying HWND --
+        // QPMDiveWindowSurface depends on that
+        if (extra && extra->topextra) {
+            delete extra->topextra->backingStore;
+            extra->topextra->backingStore = 0;
+            // zero the to-be-destroyed frame HWND just in case
+            extra->topextra->fId = NULLHANDLE;
+        }
+        // now destroy HWND
+        qt_WinDestroyWindow(old_fid);
+    }
+
     setWinId(0);
 
@@ -1506 +1514 @@
         setWindowTitle_helper(extra->topextra->caption);
     }
-    if (old_fid != NULLHANDLE)
-        qt_WinDestroyWindow(old_fid);
 
     if (q->testAttribute(Qt::WA_AcceptDrops) || dropSiteWasRegistered

trunk/src/gui/painting/qwindowsurface_pm.cpp ¶

@@ -368 +368 @@
         if (widget == that->window())
             return &data;
-        if (!subWidgets || !subWidgets->contains(widget->winId()))
+        if (!subWidgets || !subWidgets->contains(widget->internalWinId()))
             return 0;
-        return &(*subWidgets)[widget->winId()];
+        return &(*subWidgets)[widget->internalWinId()];
     }
 
@@ -379 +379 @@
 void QPMDiveWindowSurfacePrivate::addWidget(QWidget *widget)
 {
+    Q_ASSERT(widget->internalWinId());
+
     WidgetData *wd = &data;
     if (widget != that->window()) {
@@ -384 +386 @@
         if (!subWidgets)
             subWidgets = new QMap<HWND, WidgetData>();
-        wd = &(*subWidgets)[widget->winId()];
+        wd = &(*subWidgets)[widget->internalWinId()];
     }
 
@@ -398 +400 @@
         // to handle other PM messages
         widget->addPmEventFilter(this);
-        WinSetVisibleRegionNotify(widget->winId(), TRUE);
+        WinSetVisibleRegionNotify(widget->internalWinId(), TRUE);
     } else {
         // receive various PM messages
         widget->addPmEventFilter(this);
-        // receive reparent/destruction messages from children
-        // to cleanup the map
+        // receive reparent messages from children to cleanup the map
         widget->installEventFilter(this);
     }
@@ -411 +412 @@
 {
     if (widget == that->window()) {
-        WinSetVisibleRegionNotify(widget->winId(), FALSE);
+        WinSetVisibleRegionNotify(widget->internalWinId(), FALSE);
         widget->removePmEventFilter(this);
     } else {
         widget->removeEventFilter(this);
         widget->removePmEventFilter(this);
-    }
-
-    if (widget != that->window())
-        subWidgets->remove(widget->winId());
+        subWidgets->remove(widget->internalWinId());
+    }
 }
 
@@ -425 +424 @@
 {
     QWidget *widget = qobject_cast<QWidget *>(obj);
-    if (event->type() == QEvent::ParentAboutToChange ||
-        event->type() == QEvent::Destroy) {
+    if (event->type() == QEvent::ParentAboutToChange) {
         removeWidget(widget);
     }
@@ -482 +480 @@
         }
         case WM_SIZE: {
-            if (msg->hwnd != that->window()->winId()) {
+            if (msg->hwnd != that->window()->internalWinId()) {
                 // sometimes PM doesn't send WM_VRNENABLED to the main widget
                 // when the sub-widget (its descendant) gets resized within it;
@@ -611 +609 @@
         // produce a clip region that excludes all descending obstacles
         // (like child widgets with real HWNDs which are not excluded by Qt)
-        HWND wwnd = widget->winId();
+        HWND wwnd = widget->internalWinId();
         RECTL wrcl = { wbr.left(), wh - wbr.bottom() - 1,
                        wbr.right() + 1, wh - wbr.top() };
@@ -659 +657 @@
 bool QPMDiveWindowSurface::adjustSetup(QWidget *widget)
 {
-    HWND hwnd = window()->winId();
+    HWND hwnd = window()->internalWinId();
 
     // don't include lScreenPosX and the rest by default
@@ -693 +691 @@
         ULONG rc = WinQueryVisibleRegion(hwnd, hrgn);
         if (rc != RGN_ERROR) {
-            HWND hwndWidget = widget->winId();
+            HWND hwndWidget = widget->internalWinId();
             POINTL ptlOffset = { 0, 0 };
             if (hwnd != hwndWidget) {