Opened 2 years ago

Last modified 18 months ago

#361 reopened enhancement

It should be possible to clear the search highlighting by searching on an empty search string.

Reported by: Gregg Young Owned by: Gregg Young
Priority: minor Milestone: 1.4.1
Component: Backend Version: 1.4.0
Keywords: Cc: steve53@…

Description


Change History (8)

comment:1 Changed 2 years ago by Steven Levine

Cc: steve53@… added

comment:2 Changed 2 years ago by Gregg Young

Milestone: Future1.4.1

comment:3 Changed 2 years ago by Gregg Young

Owner: set to Gregg Young
Status: newassigned

comment:4 Changed 22 months ago by Lewis Rosenthal

This does work as described for me in 1.4.1 RC1, however:

  • only hits on the current page are highlighted (not the entire document);
  • moving to a subsequent page and searching for the same criteria will toggle highlights on for the new page and off for the original page;
  • searching for empty criteria from a different page will clear the highlights on the page last searched.

I thought that searching was supposed to highlight all occurrences throughout the document.

comment:5 Changed 21 months ago by Gregg Young

Did it ever highlight the whole document? The change to fix this shouldn't effect the regular search highlighting because this code is only accessed if the search string lens is 0.

comment:6 Changed 19 months ago by Gregg Young

Resolution: fixed
Status: assignedclosed

This traps sometimes. Which was fixed by CS [700]

comment:7 Changed 19 months ago by Lewis Rosenthal

Resolution: fixed
Status: closedreopened

Actually, this is not working for me. I have to go back to where I started the last search and there, search on an empty string. If I just do that from several hits into the document (different pages), the page where I have stopped searching does not un-highlight.

comment:8 Changed 18 months ago by Gregg Young

This should be fixed in 1.5.0.1 GA

Note: See TracTickets for help on using tickets.