Opened 5 years ago

Closed 5 years ago

#73 closed defect (fixed)

Settings in lSwitcher's properties notebook are always saved?

Reported by: Alfredo Fernández Díaz Owned by:
Priority: major Milestone: 2.9.1
Component: core Version: 2.9.0
Keywords: Cc:

Description

While translating the manual, I just installed the latest 2.91rc1 from the dev list on a fresh AOS 5 to test the Spanish resources in a live environment, and try to keep UI and docs well in synch.

I quickly found out that both buttons 'Save' and 'Cancel' at the bottom of the Properties notebook do nothing and the same thing -- I tried a few settings (filters, and display properties of the tb, pmwp hints) and they all seem to be saved right away, which in turn renders both buttons useless.

Change History (3)

comment:1 Changed 5 years ago by Gregg Young

Actually this isn't exactly what is happening. Save saves the changes to the ini file cancel doesn't. The issue is cancel doesn't reset things changed to the prior value until the program is restarted. I am guessing what you expect is the changes to be reverted. This has always worked this way. If I am correct in what you are looking for it should be easy to fix.

comment:2 Changed 5 years ago by Alfredo Fernández Díaz

Since you released RC2 I will be trying that and reporting again very soon, as all the following might be a moot point by now -- I just wanted to have it written here. What I always expect is consistency between functionality and what can be inferred from UI labels:

  1. My rusty, trusty lSwitch 2.7 properties notebook has three buttons labeled 'Save', 'Hide', and 'Exit', meaning any new settings always, which always come into effect, are saved to disk only when I press 'Save', but not if I press 'Hide' (which merely closes the notebook) -- so, after I close the program (e.g. by pressing 'Exit') and start it again, the settings will revert to their old values, unless I pressed 'Save'. So everything worked as it was supposed to.
  1. The newest RC1 had 'Save', 'Cancel', and 'Help', instead, with 'Save' meaning the same as above. Now, if only 'Save' writes the settings to file, what is the point of having a 'Cancel' button at all, unless it *does* do something else? I sure expected this 'something else' to be reversion of the changes (e.g. by reading them again from file), however RC did not only not reverse them, but it *also* saved then to file, effectively turning it into a clone of its sibling the 'Save' button:

-Open the properties notebook, and make some obvious change (f.e. I always turn on/off task grouping). It should come into effect immediately, which is all well and good.
-Hit 'Cancel', then MB2-click on the taskbar, and exit lSwitch.
-Start lSwitch again. Your setting should be reverted to its original state, but it won't.

As I said, will be checking RC2 in a minute, now the above is for reference (I just double-checked with RC1).

comment:3 Changed 5 years ago by Alfredo Fernández Díaz

Resolution: fixed
Status: newclosed

As discussed in lswitcher-dev, v2.90 rc3 restores v2.70 behavior and notebook button labels 'Save' and 'Hide', so this is resolved.

Note: See TracTickets for help on using tickets.