Opened 9 years ago

Closed 8 years ago

#93 closed defect (fixed)

kmk: crashes if Path ends with a qutoed string on Windows

Reported by: bird Owned by: bird
Priority: major Milestone: 0.2.0
Component: kmk Version: 0.1.5
Keywords: kmk windows path crash Cc:

Description

GNU make bug. Path=...;"C:\Program Files\Debugging Tools for Windows (x86)" leads to crash with the following backtrace:

0:000> k
ChildEBP RetAddr  
0012f12c 00420fd6 kmk!convert_Path_to_windows32+0xc7 [e:\coding\kbuild\svn\trunk\src\kmk\w32\pathstuff.c @ 79]
0012f1b8 0042f49e kmk!target_environment+0x2f6 [e:\coding\kbuild\svn\trunk\src\kmk\variable.c @ 1623]
0012f1d8 0042f736 kmk!start_job_command+0x44e [e:\coding\kbuild\svn\trunk\src\kmk\job.c @ 1346]
0012f1e8 004302db kmk!start_waiting_job+0x1a6 [e:\coding\kbuild\svn\trunk\src\kmk\job.c @ 1664]
0012f210 004225df kmk!new_job+0x2db [e:\coding\kbuild\svn\trunk\src\kmk\job.c @ 1967]
0012f230 004330f6 kmk!execute_file_commands+0x6f [e:\coding\kbuild\svn\trunk\src\kmk\commands.c @ 517]
0012f270 004333ac kmk!update_file_1+0xeb6 [e:\coding\kbuild\svn\trunk\src\kmk\remake.c @ 920]
0012f28c 004338ff kmk!update_file+0xbc [e:\coding\kbuild\svn\trunk\src\kmk\remake.c @ 318]
0012f2c8 004043b7 kmk!update_goal_chain+0x11f [e:\coding\kbuild\svn\trunk\src\kmk\remake.c @ 162]
0012ff28 00444bdb kmk!main+0x11f7 [e:\coding\kbuild\svn\trunk\src\kmk\main.c @ 2477]

The workaround is to add a trailing semi colon (;) to the Path environment variable or simply drop the quoting (it's not actually required on >= NT).

Change History (3)

comment:2 Changed 18 years ago by bird

  • Milestone set to 0.2.0
  • Status changed from new to assigned

comment:2 Changed 8 years ago by bird

  • Resolution set to fixed
  • Status changed from assigned to closed

Applied the patch in [2454].

Note: See TracTickets for help on using tickets.