Opened 9 years ago

Closed 8 years ago

Last modified 8 years ago

#12 closed enhancement (fixed)

Make sure os::dll_load() can load OS/2 DLLs

Reported by: dmik Owned by:
Priority: major Milestone: RC2
Component: general Version:
Severity: low Keywords:
Cc:

Description

As we are based on the Windows code, the current implementation of ps::dll_load() assumes a Windows (PE) DLL is supplied it. We will also want to load OS/2 DLLs as well.

Change History (4)

comment:1 Changed 9 years ago by dmik

  • Type changed from defect to enhancement

comment:2 Changed 9 years ago by dmik

  • Milestone changed from RC to GA

comment:3 Changed 8 years ago by dmik

  • Resolution set to fixed
  • Severity set to low
  • Status changed from new to closed

In rxxx, I fixed a bunch of Win32-specific code in os::dll_load() (that would attempt to parse the DLL file on failure thinking it's a PE and looking for an architecture field which resulted in a weird message about the architecture mismatch if some Java DLL can't be loaded) and improved error handling a bit (Odin r 21604).

And, for sure, os::dll_load() can load native OS/2 DLLs -- it uses LoadLibrary?() which in turn tries DosLoadModule?() among other things. So the problem was just a cosmetic one.

comment:4 Changed 8 years ago by dmik

rxxx = r277.

Note: See TracTickets for help on using tickets.