Opened 17 years ago
Closed 17 years ago
#74 closed task (fixed)
Cleanup DOROT13 macro in MLE.c
| Reported by: | Gregg Young | Owned by: | Gregg Young |
|---|---|---|---|
| Priority: | minor | Milestone: | Release_3.5.9 |
| Component: | fm/2 base | Version: | 3.05 |
| Keywords: | Cc: |
Description
mle.c(299:12) : informational EDC0424: The condition is always true. mle.c(299:12) : informational EDC0425: The condition is always false.
*p = DOROT13(*p); fixme condition both true and false?
this a case of silly code that has been there forever. The fixme is mine, added as a note to remove the silliness someday. Mark's code near line 37 reads
#define FAKEROT 1 #define DOROT13(c) ((FAKEROT==0)?(c):(FAKEROT==1)?etc...
This should be rewritten
#define FAKEROT 1 Set to 1 or 0 !if FAKEROT == 0 #define DOROT13(c) alogo1... #else #define DOROT13(c) alogo2... #endif
Change History (2)
comment:1 Changed 17 years ago by
| Type: | defect → task |
|---|
comment:2 Changed 17 years ago by
| Milestone: | → Release_3.5.9 |
|---|---|
| Resolution: | → fixed |
| Status: | new → closed |
Note: See
TracTickets for help on using
tickets.
