Opened 10 years ago
Closed 10 years ago
#554 closed defect (fixed)
Trap on rescan following rename caused by pci->pszFileName being NullStr
| Reported by: | Gregg Young | Owned by: | Gregg Young |
|---|---|---|---|
| Priority: | minor | Milestone: | Release_3.24 |
| Component: | fm/2 base | Version: | 3.23 |
| Keywords: | Cc: |
Description (last modified by )
After I "fixed" the direct edit code it would leave a blank directory line above or below the renamed directory. I added a rescan and the problem was covered up. This seemed fine until it trapped. I traced the trap to UM_RESCAN2 treecnr.c ~791
if (pci && (INT) pci != -1 && pci->pszFileName != NullStr) { //fixme? will try checking pci->pszFileName instead of the pointer
if (!(driveflags[toupper(*pci->pszFileName) - 'A'] &
DRIVE_REMOVABLE) ||
driveserial[toupper(*pci->pszFileName) - 'A'] != -1) {
I added the != NullStr which fixed the trap. I can see we had problems with this in the past based on the fixme. Hopefully this fixed that problem also.
Attachments (2)
Change History (6)
comment:1 by , 10 years ago
| Description: | modified (diff) |
|---|
by , 10 years ago
| Attachment: | 0C87_06.TRP added |
|---|
by , 10 years ago
| Attachment: | 0C87_0E.TRP added |
|---|
comment:2 by , 10 years ago
comment:3 by , 10 years ago
| Owner: | set to |
|---|---|
| Status: | new → assigned |
Note:
See TracTickets
for help on using tickets.
Note this was a double trap. Both are attached