Opened 4 years ago

Closed 2 years ago

Last modified 2 years ago

#534 closed defect (fixed)

Trap in Stubby on startup

Reported by: gyoung Owned by: gyoung
Priority: minor Milestone: Release_3.24
Component: fm/2 base Version: 3.21
Keywords: Cc:

Description (last modified by gyoung)

Fix was not adequate needed (INT) pci != -1 check

Attachments (1)

012E_0C.TRP (33.1 KB) - added by gyoung 4 years ago.

Download all attachments as: .zip

Change History (9)

Changed 4 years ago by gyoung

comment:1 Changed 4 years ago by gyoung

The second check is where the trap occurred:

if (!pciParent
!*pciParent->pszFileName !hwndCnr) flesh.c ~279

there are some clues. It almost seems like pciParent was not yet fully initialized when the trap occurred. By our rules, under normal conditions, pszFileName is never NULL.

EDX points to pciParent, so we can look at its contents. At the time the ..trp file was written [edx+0x20] contains a valid pointer. You may have an SMP timing race.

I have a full trap dump pdump.292

comment:2 Changed 3 years ago by gyoung

  • Milestone changed from Release_3.23 to Release_3.24

Ticket retargeted after milestone closed

comment:3 Changed 2 years ago by stevenhl

  • Milestone changed from Release_3.24 to Release_3.25

comment:4 Changed 2 years ago by gyoung

  • Owner set to gyoung
  • Status changed from new to assigned

Since I have now seen several traps due to pci->pszFileName being NullStr?. I will add this check which should eliminate this trap. CS[1832]

comment:5 Changed 2 years ago by gyoung

  • Resolution set to fixed
  • Status changed from assigned to closed

comment:6 Changed 2 years ago by gyoung

  • Description modified (diff)
  • Resolution fixed deleted
  • Status changed from closed to reopened

comment:7 Changed 2 years ago by gyoung

  • Resolution set to fixed
  • Status changed from reopened to closed

CS [1837]

comment:8 Changed 2 years ago by gyoung

  • Milestone changed from Release_3.25 to Release_3.24
Note: See TracTickets for help on using tickets.