Opened 11 years ago

Closed 9 years ago

Last modified 9 years ago

#534 closed defect (fixed)

Trap in Stubby on startup

Reported by: Gregg Young Owned by: Gregg Young
Priority: minor Milestone: Release_3.24
Component: fm/2 base Version: 3.21
Keywords: Cc:

Description (last modified by Gregg Young)

Fix was not adequate needed (INT) pci != -1 check

Attachments (1)

012E_0C.TRP​ (33.1 KB ) - added by Gregg Young 11 years ago.

Download all attachments as: .zip

Change History (9)

by Gregg Young, 11 years ago

Attachment: 012E_0C.TRP​ added

comment:1 by Gregg Young, 11 years ago

The second check is where the trap occurred:

if (!pciParent
!*pciParent->pszFileName !hwndCnr) flesh.c ~279

there are some clues. It almost seems like pciParent was not yet fully initialized when the trap occurred. By our rules, under normal conditions, pszFileName is never NULL.

EDX points to pciParent, so we can look at its contents. At the time the ..trp file was written [edx+0x20] contains a valid pointer. You may have an SMP timing race.

I have a full trap dump pdump.292

comment:2 by Gregg Young, 10 years ago

Milestone: Release_3.23 → Release_3.24

Ticket retargeted after milestone closed

comment:3 by Steven Levine, 9 years ago

Milestone: Release_3.24 → Release_3.25

comment:4 by Gregg Young, 9 years ago

Owner: set to Gregg Young
Status: new → assigned

Since I have now seen several traps due to pci->pszFileName being NullStr. I will add this check which should eliminate this trap. CS[1832]

comment:5 by Gregg Young, 9 years ago

Resolution: → fixed
Status: assigned → closed

comment:6 by Gregg Young, 9 years ago

Description: modified (diff)
Resolution: fixed
Status: closed → reopened

comment:7 by Gregg Young, 9 years ago

Resolution: → fixed
Status: reopened → closed

CS [1837]

comment:8 by Gregg Young, 9 years ago

Milestone: Release_3.25 → Release_3.24
Note: See TracTickets for help on using tickets.