Opened 9 years ago

Closed 7 years ago

Last modified 7 years ago

#52 closed defect (fixed)

History is not consistently saved (perhaps not saved when close button is used)

Reported by: Gregg Young Owned by: Gregg Young
Priority: minor Milestone: Release_1.1
Component: eFTEPM Version: PreRelease_1.0
Keywords: Cc:

Description


Change History (9)

comment:1 by Gregg Young, 9 years ago

It works as expected using exit but isn't saved when the close button is used.

comment:2 by Gregg Young, 9 years ago

Owner: set to Gregg Young
Status: newaccepted

comment:3 by Gregg Young, 9 years ago

Version: PreRelease_1.0

comment:4 by Gregg Young, 9 years ago

Summary: History is not consistently save(perhaps not saved when close button is used)History is not consistently saved (perhaps not saved when close button is used)

comment:5 by Gregg Young, 9 years ago

Milestone: Release_1.0Release_1.1

comment:6 by Alfredo Fernández Díaz, 7 years ago

Component: eFTE coreeFTEPM

I just tried and history seems to be saved here -- this should affect only the PM version anyway (no toolbar in VIO; do other platforms have toolbars?).

Relevant changes to g_pm.cpp are mentioned in Changeset 174, and the code looks kosher to me. I will close this as 'fixed' in a week if no more comments are made.

comment:7 by Gregg Young, 7 years ago

Resolution: fixed
Status: acceptedclosed

CS [174}

comment:8 by Gregg Young, 7 years ago

Note this fix changed a return code that could affect other platforms. egui.cpp int EGUI::ExitEditor(EView * View) the return was changed from 1 to 0 (line ~587) to make this work.

comment:9 by Alfredo Fernández Díaz, 7 years ago

I didn't go into the changeset deep enough to notice that--it still may take me a while to wrap my head around many parts anyway.

Isn't egui.cpp linked into the VIO version as well? If so, that might give us a pointer to what else we should be testing before forgetting about this.

Note: See TracTickets for help on using tickets.