#52 closed defect (fixed)
History is not consistently saved (perhaps not saved when close button is used)
Reported by: | Gregg Young | Owned by: | Gregg Young |
---|---|---|---|
Priority: | minor | Milestone: | Release_1.1 |
Component: | eFTEPM | Version: | PreRelease_1.0 |
Keywords: | Cc: |
Description
Change History (9)
comment:1 by , 9 years ago
comment:2 by , 9 years ago
Owner: | set to |
---|---|
Status: | new → accepted |
comment:3 by , 9 years ago
Version: | → PreRelease_1.0 |
---|
comment:4 by , 9 years ago
Summary: | History is not consistently save(perhaps not saved when close button is used) → History is not consistently saved (perhaps not saved when close button is used) |
---|
comment:5 by , 9 years ago
Milestone: | Release_1.0 → Release_1.1 |
---|
comment:6 by , 7 years ago
Component: | eFTE core → eFTEPM |
---|
I just tried and history seems to be saved here -- this should affect only the PM version anyway (no toolbar in VIO; do other platforms have toolbars?).
Relevant changes to g_pm.cpp are mentioned in Changeset 174, and the code looks kosher to me. I will close this as 'fixed' in a week if no more comments are made.
comment:8 by , 7 years ago
Note this fix changed a return code that could affect other platforms. egui.cpp int EGUI::ExitEditor(EView * View) the return was changed from 1 to 0 (line ~587) to make this work.
comment:9 by , 7 years ago
I didn't go into the changeset deep enough to notice that--it still may take me a while to wrap my head around many parts anyway.
Isn't egui.cpp linked into the VIO version as well? If so, that might give us a pointer to what else we should be testing before forgetting about this.
It works as expected using exit but isn't saved when the close button is used.