trap 3 Open Watcom build

[abwillis]

Seeing that the Open Watcom build was now working I decided to give it a try just to see if it would make a difference with ticket #11. It doesn't but that wasn't unexpected. It was unexpected that there is an int 3 call in devhelp.h DevHelp_VirtToPhys. The int 3 seems to get called on each boot, removing the int 3 allows the boot to proceed. This ticket may be premature but the r144 says that it fixed the Open Watcom build.

[rousseau]

Replying to abwillis:

Seeing that the Open Watcom build was now working I decided to give it a try just to see if it would make a difference with ticket #11. It doesn't but that wasn't unexpected. It was unexpected that there is an int 3 call in devhelp.h DevHelp_VirtToPhys. The int 3 seems to get called on each boot, removing the int 3 allows the boot to proceed. This ticket may be premature but the r144 says that it fixed the Open Watcom build.

The int 3 at devhelp.h should be commented out.
Maybe your environment does not use the devhelp.h in os2ahci\src\include ?
This is an excerpt of the code around devhelp.h line 919.
Note the semi-colon in front of the int 3.

USHORT DevHelp_VirtToPhys(PVOID SelOffset, PULONG PhysAddr);
#pragma aux DevHelp_VirtToPhys = \
   ";int 3" \
   "push ds" \
   "mov  dl,16h" \
   "push es" \

Your issue is also being looked into but I don't have the hardware
to reproduce it and I need some more time to grasp it.

[rousseau]

Replying to rousseau:

Replying to abwillis:

Seeing that the Open Watcom build was now working I decided to give it a try just to see if it would make a difference with ticket #11. It doesn't but that wasn't unexpected. It was unexpected that there is an int 3 call in devhelp.h DevHelp_VirtToPhys. The int 3 seems to get called on each boot, removing the int 3 allows the boot to proceed. This ticket may be premature but the r144 says that it fixed the Open Watcom build.

Buh, I checked and you are correct.
Somehow devhelp.h did not make it to the repo, not even in r145.
Corrected in r146.
Please let me know if it solves the issue so I can close it.
Thanks !

[abwillis]

Indeed that did fix it... it was simpler than what I had done:
/*"int 3" */ \

[rousseau]

Replying to abwillis:

Indeed that did fix it... it was simpler than what I had done:
/*"int 3" */ \

Well, leaving a space between the semi-colon and the instruction
does not get interpreted well by inline _asm{} (Wasm),
so your commenting-out is arguably better. (C-level)

Anyway, I close this ticket.
OS2AHCI is now buildable with Open Watcom from this repo,
and functional, due to your observations.
Thanks again!

---
Please keep in mind that any OW build is not as "baptized" as
an IBMDDK one and should be treated as beta for the time being.
---