Opened 10 years ago

Closed 6 years ago

#378 closed task (fixed)

Implement standard form build level strings for all ACPI binaries

Reported by: stevenhl Owned by:
Priority: major Milestone: Release version 3.19
Component: ACPI PSD Version: 3.14
Keywords: Cc:

Description

This will provide a human-readable unique identifier for each binary that we install. The date and time recorded in the build level string should be the date and time the binary was built.

Attachments (1)

Bldlevel.ref (2.1 KB) - added by stevenhl 10 years ago.
Bldlevel string documentation

Download all attachments as: .zip

Change History (12)

comment:1 Changed 10 years ago by stevenhl

Your change is a good start.

However, you need to create bldlevel.c and not bldlevel.h. Then compile and link bldlevel.obj into acpi.psd. They way you did it does not reduce the build time. It probably increases it.

Perhaps you misread my original e-mail.

comment:2 Changed 10 years ago by pasha

Perhaps you misread my original e-mail, I very very very very very don't want create as obj. If you want bldlevel.c I rename bldlevel.h. But *IT DON'T BE AS OBJ!!!!" More. as you know, if this char * be moved to another place we can has don't load psd. Also you can try remove \0x0\0x0\0xb from this string, result be same. Questions is open. Why you want do compile hard and debuging process long.

Do you want time in bldlevel? It here now. What is need more?

comment:3 Changed 10 years ago by stevenhl

The build level string is already in a object file and always has been. After the preprocessor runs, the input to the compiler is exactly the same as what you had before.

What possible difference can it make which object file the string is defined in? You have almost no control over where the string is linked into the acpi.psd.

I know that there is a defect that prevents us from putting the string in the description block, but that is not what I am suggesting. Have you tried my suggestion?

comment:4 follow-up: Changed 10 years ago by pasha

Ok. Back.

  1. if I compile ALWAYS - I have more hard debug. Questions, why you want to do my debug hard?
  2. bldelvel string ALWAYS is in psd.obj
  3. Always compile files is moveton in programming
  4. Where is standard for "Implement standard form build level strings for all ACPI binaries" ?

If you want in bldlevel.c as dedicated file - OK. We will have different version of acpi svn. I do as _easy_ work to me and create svn for your happy.

And I have interested. You need in string or you need, that all doing as you want? And mention to me. Need do acpi, or need do bldlevel string as _you_ want.

Ok. I see, what we can't have agreement. So, now I be don't put to mensys ftp and be send via e-mail. Output packet with change version always has right string.

Also. Before I think, that you suggestion need look as soviet. I don't agree with this your soviet.

BTW, where I must be placed open book of acpi standard in my table? from right or from left? Now I use from left, may be it don't true? May be standard of place book is another?

comment:5 Changed 10 years ago by mckinnis

The build level needs to contain either a date/time stamp or a build number. There are currently many builds that report themselves as 3.14. Which 3.14? Otherwise, how can one ever determine what level of the code is causing the problem.

For example: bldlevel danis506.add . . Date/Time?: 12.5.2008 17:06:29 . File Version: 1.8.5 .

comment:6 Changed 10 years ago by pasha

Bldlevel is in binary. All walking around stone is "must be real time in bldlevel or no" Real time produce long compiling and hard debug. BTW WTF real time? ;-) Here setting my time with +2GMT. As I say. I don't do this. If you very very very want - in svn be as you want and I will send file via email, so you don't see this file and questions be close.

Changed 10 years ago by stevenhl

Bldlevel string documentation

comment:7 in reply to: ↑ 4 ; follow-up: Changed 10 years ago by stevenhl

  1. if I compile ALWAYS - I have more hard debug. Questions, why you want to do my debug hard?

What don't you understand? No one has every asked you to compile always. Perhaps it will be easier for you to discuss this on IRC?

  1. bldelvel string ALWAYS is in psd.obj

That is true now. I am recommending you put it in bldlevel.c so that you don't need to recompile psd.c every time you run nmake.

  1. Always compile files is moveton in programming

Huh?

  1. Where is standard for "Implement standard form build level strings for all ACPI binaries" ?

Attached to the ticket, now that you have asked.

If you want in bldlevel.c as dedicated file - OK. We will have different version of acpi svn. I do as _easy_ work to me and create svn for your happy.

You don't need to add bldlevel.c to svn, but I recommend you do so. This is no different than adding bldlevel.h. It allows us another way to correlate binary builds to specific svn changesets is submit the current bldlevel.c to svn after you do the release build. The fact that bldlevel.c will change each time someone does a build is irrelevant. For example, we have acpi.cmd in svn, which is as it should be. Acpi.cmd works only on your system, so every one needs to maintain a private copy and be careful not to commit this copy to svn.

And I have interested. You need in string or you need, that all doing as you want? And mention to me. Need do acpi, or need do bldlevel string as _you_ want.

This conversation started because you complained about the time it would take to recompile acpi.psd if the bldlevel string changed every time you ran nmake. I gave you a solution that avoids this problem. Perhaps you don't understand my solution and we should discuss it on IRC.

Ok. I see, what we can't have agreement. So, now I be don't put to mensys ftp and be send via e-mail. Output packet with change version always has right string.

What are you talking about?

Also. Before I think, that you suggestion need look as soviet. I don't agree with this your soviet.

What are you saying? It just so happens that my grandparents came from Minsk, but I am not Russian.

BTW, where I must be placed open book of acpi standard in my table? from right or from left?

I really do hope you enjoy being silly. It's not terribly professional.

comment:8 in reply to: ↑ 7 ; follow-up: Changed 10 years ago by pasha

Replying to stevenhl:

  1. if I compile ALWAYS - I have more hard debug. Questions, why you want to do my debug hard?

What don't you understand? No one has every asked you to compile always. Perhaps it will be easier for you to discuss this on IRC?

If file be created - this file be compiled.

  1. bldelvel string ALWAYS is in psd.obj

That is true now. I am recommending you put it in bldlevel.c so that you don't need to recompile psd.c every time you run nmake.

I need rename bldlevel.h to bldlvel.c ? no problem. do it?

  1. Always compile files is moveton in programming

Huh?

Always compile mean error. In common case.

  1. Where is standard for "Implement standard form build level strings for all ACPI binaries" ?

Attached to the ticket, now that you have asked.

I don't see this standard. I see only your talks about it.

If you want in bldlevel.c as dedicated file - OK. We will have different version of acpi svn. I do as _easy_ work to me and create svn for your happy.

You don't need to add bldlevel.c to svn, but I recommend you do so. This is no different than adding bldlevel.h. It allows us another way to correlate binary builds to specific svn changesets is submit the current bldlevel.c to svn after you do the release build. The fact that bldlevel.c will change each time someone does a build is irrelevant. For example, we have acpi.cmd in svn, which is as it should be. Acpi.cmd works only on your system, so every one needs to maintain a private copy and be careful not to commit this copy to svn.

Need remove this cmd from svn?

And I have interested. You need in string or you need, that all doing as you want? And mention to me. Need do acpi, or need do bldlevel string as _you_ want.

This conversation started because you complained about the time it would take to recompile acpi.psd if the bldlevel string changed every time you ran nmake. I gave you a solution that avoids this problem. Perhaps you don't understand my solution and we should discuss it on IRC.

I agree with your bldlevel string, I agree create it in cmd or makefile. But I don't agree insert bldlevel.c as dedicated obj in makefile. You can do it via Roderick. In svn be right version for you, in me be right version for me. I say this as fact. Then your choice. If say this to me - in svn you be happy.

Ok. I see, what we can't have agreement. So, now I be don't put to mensys ftp and be send via e-mail. Output packet with change version always has right string.

What are you talking about?

As I have understanding , you want, that I have right time in psd independently, send this psd to user or no. Read my letter about USSR. Now I agree at all. Need do your suggestion to svn?

comment:9 in reply to: ↑ 8 Changed 10 years ago by stevenhl

Replying to pasha:

Replying to stevenhl:

If file be created - this file be compiled.

As I mentioned elsewhere, this only needs to occur for builds that will be distributed for external testing. Do you understand this?

I need rename bldlevel.h to bldlvel.c ? no problem. do it?

I would, but it is up to you.

  1. Always compile files is moveton in programming

Huh?

Always compile mean error. In common case.

If you are referring to the spurious syntax error, we need to resolve this for you.

I don't see this standard. I see only your talks about it.

Please don't argue about this. This is as close to a standard as you will find. If you think any of the content is wrong, tell me where.

build is irrelevant. For example, we have acpi.cmd in svn, which is as it should be. Acpi.cmd works only on your system, so every one needs to maintain a private copy and be careful not to commit this copy to svn.

Need remove this cmd from svn?

No. It a sample, that is a good starting point for anyone that wants to build acpi. The same applies to setenv.cmd. It too is a sample that others need to modify for their individual seutp.

I agree with your bldlevel string, I agree create it in cmd or makefile. But I >don't agree insert bldlevel.c as dedicated obj in makefile.

OK. Leave it as bldlevel.h. I still think you will eventually find it easier to have a bldlevel.c rather than a bldlevel.h, but either way can work.

As I have understanding , you want, that I have right time in psd independently, send this psd to user or no.

No. We need to have a unique timestamp in the builds you distribute to external users. I don't care what timestamps, if any, your internal builds have. I have never cared. The only reason this occurs is because of how you implemented the code that creates bldlevel.h. The only reason you are getting the recompiles for your internal builds is because of how you implemented the code that creates bldlevel.h

comment:10 Changed 10 years ago by pasha

  • Owner pasha deleted

comment:11 Changed 6 years ago by dazarewicz

  • Resolution set to fixed
  • Status changed from new to closed
Note: See TracTickets for help on using tickets.