Opened 10 years ago

Closed 10 years ago

#27 closed defect (fixed)

ESET and BEGINLIBPATH/ENDLIBPATH

Reported by: KO Myung-Hun Owned by: Steven Levine
Priority: minor Milestone: Version-3.09
Component: Commands Version: 3.08
Keywords: Cc:

Description

Hi/2.

ESET is a great feature of 4OS2. BTW, it does work with BEGINLIBPATH/ENDLIBPATH. Even if I modify them with ESET, its result is not applied actually.

Change History (6)

comment:1 by Steven Levine, 10 years ago

Owner: set to Steven Levine
Status: newaccepted

Hi,

Interesting defect. What you are seeing is the combination of a number of interacting defects/omissions.

get_list() does not supply a "varname=" prefix when returning values for BEGINLIBPATH etc. This confuses other code with expects the variable name to be returned as part of the returned string.

cmd_eset() does not check for nLength 0 (i.e. the variable name length), probably because it assumes that this can not occur.

put_list() does not notice that the supplied string does not contain a variable name or equal character. It probably should report this as an error even though the condition should never occur.

Given the above, put_list() does insert the string in the environment, but not in a useful way.

The fix should be relatively easy. I plan to modify get_list() to return the missing variable name and equals character.

comment:2 by Steven Levine, 10 years ago

Please try

ftp://ftp.netlabs.org/incoming/4os2-3.08-shl-2014-09-15.zip

The fix needed to go into cmd_eset(), but that's details.

comment:3 by KO Myung-Hun, 10 years ago

I've tested. And I've confirmed that eset worked well with beginlibpath/endlibpath. But I've found another problem. After ESET BEGINLIBPATH/ENDLIBPATH, LIBPATHSTRICT is changed.

set beginlibpath=x:\path
set libpathstrict=T
eset beginlibpath [just enter, do not change contents]
set libpathstrict

Then, you can see [T:\path]. This is true for ENDLIBPATH, and does not occur original 3.08.

comment:4 by Steven Levine, 10 years ago

ftp://ftp.netlabs.org/incoming/4os2-3.08-shl-2014-09-24.zip

should resolve this. I neglected to nul terminate the value returned by DosQueryExtLIBPATH.

comment:5 by KO Myung-Hun, 10 years ago

I've confirmed. It works well. Thanks.

Ah, BTW, my mail to you was blocked.


Connected to 209.86.93.229 but sender was rejected...Remote host said:>>>550 IP 203.252.1.122 is blocked by EarthLink. Go to earthlink.net/block for details.


Last time, there was no problem.

comment:6 by Steven Levine, 10 years ago

Resolution: fixed
Status: acceptedclosed

Corrected by PerForce changeset 37556.

Note: See TracTickets for help on using tickets.