| 2 | | VBOXFSFind.cpp, "FillFindBuf": as I mentioned in my last comment, here we are lacking the KernSelToFlat calls to properly thunk peaop->fpGEAList and peop->fpFEAList. |
| 3 | | I recommend to move these 2 thunking calls into GetEmptyEAS itself and remove them from anywhere else. That is much more understandable and less error prone. |
| | 2 | VBOXFSFind.cpp, "FillFindBuf": I recommend to move the thunking calls for peaop->fGEAList and peaop->fFEAList into GetEmptyEAS itself and remove them from anywhere else. That is much more understandable and less error prone. |
| | 3 | |
| | 4 | It is also incorrect to thunk these two pointers and copy them back into the EAOP return structure. These pointers HAVE to remain 16:16 far pointers in the returned kernel structure. |
| | 5 | In fact the EAOP structure has to remain completely UNCHANGED in the return buffer. |
