Custom Query (45 matches)

A fresh bunch of patches by valorous is made against revision 58105 of the OSE SVN (​https://www.virtualbox.org/changeset/58105/vbox, made on 05.10.2015). The closest official release of VirtualBox? is 5.0.6 (released on 02.10.2015).

The current OS/2 implementation of the RTPipe api uses DosCreateNPipe and friends, i.e. OS/2 native named pipes. This imposes a problem though: some cross-platform code (e.g. DrvNAT.cpp, DrvTAP.cpp) uses LIBC poll() to work with pipes created by RTPipeCreate, but OS/2 native pipes are incompatible with LIBC select() which is used there by the poll() implementation.

There are several ways to deal with that:

1. Replace RPIPE with RTSOCKET and use RTSocket instead (sockets are compatible with select()). Seems to work but creates a lot of OS/2-specific #ifdefs in the sources, not very good.
2. Change the RTPlpe implementation to use the posix code path (the one Linux uses). This implies using socketpair instead of pipe (as the latter also creates handles incompatible with select). Looks attractive as doesn't require any changes in the using code.
3. Change the using code (DrvNAT.cpp and others) to use RTPoll instead of poll as the former knows how to deal with OS/2 native pipes created with RTPipeCreate.

The supdrvSessionRetain / supdrvSessionRelease increment / decrement a reference counter for vboxdr.sys open sessions. And the release count is greater than retain count, so we got

!!Assertion Failed!!
Expression: cRefs < _1M
Location  : N:/src/vbox/src/VBox/HostDrivers/Support/SUPDrv.cpp(1364) uint32_t
supdrvSessionRelease(PSUPDRVSESSION)
0xffffffff fd3e4308

on boot. So, there will be trap 0003 on boot with current vboxdrv.sys from repo. There is a preliminary fix, which I attach to this ticket, but it is not perfect.

So, implement a proper fix.