Opened 13 years ago

Closed 13 years ago

Last modified 13 years ago

#52 closed defect (fixed)

Newer Flash modules not working

Reported by: abwillis Owned by: abwillis
Priority: major Milestone: general enhancement
Component: odin Version:
Severity: low Keywords:
Cc:

Description

Newer flash modules are not working, missing functions...

Change History (8)

comment:1 by abwillis, 13 years ago

Added an export for one module, added two other functions and exports. Committed revision 21848.

Version 0, edited 13 years ago by abwillis (next)

comment:2 by abwillis, 13 years ago

Owner: set to abwillis

comment:3 by abwillis, 13 years ago

Resolution: fixed
Status: newclosed

comment:4 by abwillis, 13 years ago

Able to now use later 10 versions and version 11.1... one oddity I have found with at least version 11, sometimes if the browser has focus the video does not play while audio does... changing focus to something else like the desktop will then cause video to play (moving the mouse around on the video will also cause it to play). This is not to say they work necessarily as well as the 10.22 version... in some cases it seems better while in others not as well.

Last edited 13 years ago by abwillis (previous) (diff)

comment:5 by dmik, 13 years ago

Andy, thanks for the commit. I have a question: does Flash try to import VerSetConditionMask() from KERNEL32.DLL? Why do you export it from both NTDLL and KERNEL32?

comment:6 by abwillis, 13 years ago

Flash calls it from Kernel32.dll. I had initially thought I needed to add the export to NDLL and import it into Kernel32 but that failed so I exported from Kernel32 and it worked then I tried removing it from NTDLL and it failed so I just added it back in. I can try again to remove it and see if it was something unaccountable at this point that caused it to fail the first time. As best I could figure out... Wine exports it from both which is why I didn't really look deeper at it.

Last edited 13 years ago by abwillis (previous) (diff)

comment:7 by dmik, 13 years ago

Okay, I checked that myself. VerSetConditionMask() is exported from both KERNEL32 and NTDLL on a real Windows machine indeed.

Only one request: could you please move these new exports after SetWaptableTimer (@3162), just to keep the .def more clean? And you also need to add the same exports to KERNEL32DBG.DEF (to make the debug build work) and also put names containing "@" in quotes (otherwise GCC builds will fail). Thanks.

comment:8 by abwillis, 13 years ago

Committed revision r21863

Note: See TracTickets for help on using tickets.