Custom Query (292 matches)

From Vitali: I've found a bug in the smbcd.c. When it is unable to connect to a share because it has no rights to access it (wrong login/pass, then the return code from smbcd was 7 (ERROR_ARENA_TRASHED). That is rather misleading :)

Further analysis showed that smbwrp_connect returned a non-0 value as an error indicator. Values numbered 1 to 7 and are not related to OS/2 error codes.

Here is a patch. I think returning ERROR_ACCESS_DENIED on the smbwrp_failure is OK.

Please make a new build for me.

Thanks in advance, Vitali.

Index: smbcd.c =================================================================== --- smbcd.c (revision 44) +++ smbcd.c (working copy) @@ -311,7 +311,7 @@

if (res->rc) {

debuglocal(1,"Client reconnect resprc %d\n", res->rc);

• return NO_ERROR;

+ return ERROR_ACCESS_DENIED;

} *reconnect = 1;

}

@@ -346,6 +346,10 @@

memcpy(srv, req->param, sizeof(smbwrp_server)); *reconnect = 1;

}

+ else + { + res->rc = ERROR_ACCESS_DENIED; + }

} break; case SMBREQ_DISCONNECT : {

Last lines of the log are:

Killed by SIGSEGV pid=0x008e ppid=0x0089 tid=0x0001 slot=0x00e8 pri=0x0400 mc=0x0001 D:\SAMBA\SMBD.EXE LIBC063 0:00053cac cs:eip=005b:1da13cac ss:esp=0053:0045d0a4 ebp=0045d0e8

ds=0053 es=0053 fs=150b gs=0000 efl=00010202

eax=0045d2f0 ebx=20032c3c ecx=00000001 edx=00000001 edi=0045d2f0 esi=00000000 Process has been dumped

Problem was discovered during my work to "port" findsmb to REXX.

smbclient.exe shows OS=[Unix] instead of OS=[OS/2] or similar.