Custom Query (31 matches)

I ran cppcheck looking for possible uninitialized variables as I have seen crashes when doing a lot of scrolling. I did not find any but found a potential memory leak. I'll let you evaluate and decide if this is meaningful.

Index: src/gui/nepmdlib/nepmdlib.c
===================================================================
--- src/gui/nepmdlib/nepmdlib.c	(revision 2946)
+++ src/gui/nepmdlib/nepmdlib.c	(working copy)
@@ -1032,7 +1032,7 @@
          HCONFIG        hconfig;
 
          CHAR           szResult[ 20];
-         PMODEINFO      pmi = malloc( 1024);
+         PMODEINFO      pmi = NULL;
 
 FUNCENTER;
 
@@ -1076,6 +1076,8 @@
    } while (FALSE);
 
 FUNCEXITRC;
+if (pmi)
+  free( pmi);
 return _getRexxError( rc, pszBuffer, ulBuflen);
 }
 

After executing

NepmdDeleteConfigTree \NEPMD\User\AutoRestore

the section RegKey is OK, but in RegContainer, the entry for \NEPMD\User was changed from

AutoRestore.AutoSave.Backup.Colors. ... .Toolbar.

to

AutoSaveBackup.Colors. ... .Toolbar.

(zero chars replaced by single dots).

The faulty function is _removeKeyFromContainerList of libreg.c, which exists for a long time.

The removed RegKeys are:

\NEPMD\User\AutoRestore\Ring\LoadLast
\NEPMD\User\AutoRestore\Ring\MaxFiles
\NEPMD\User\AutoRestore\Ring\SaveLast

The removed RegContainer keys are:

\NEPMD\User\AutoRestore\Ring
\NEPMD\User\AutoRestore

It may have relevance that two container levels were removed.

Luckily, this bug didn't appear until now. It has to be fixed before the deletion of a tree will be added to ImportUserTextConfig, triggered by a DELETE: value in user.cfg.

Esp. the mark commands do unexpected actions if nothing is marked. Additionally, not all commands exist yet.

Moreover, the key assignments for these actions should be reworked. The changes have to be implemented in newmenu and in the popup menu.