Changes between Version 12 and Version 13 of DevelopersFAQ

Timestamp:

Aug 20, 2007, 3:09:44 AM (17 years ago)

Author:

guest

Comment:

--

DevelopersFAQ

@@ -69 +69 @@
 
 ----
-
-== Coding Questions == #coding-questions
-
-=== Is the code below OK? Did I account for the terminating nulls correctly? ===
-
-{{{
-//BldFullPathName returns the fullpath of a file or Nullstr
-CHAR *FullPathName = BldFullPathName(CHAR *pathname, CHAR
-*filename)
-{
-
-CHAR newname[CCHMAXPATH] = Nullstr;
-INT c = 0;
-
-c = strlen(pathname);
-if (c > 0) {
-memcpy(newname, pathname, c + 1);
-if (newname[c] != '\\')
-newname[c++] = '\\';
-}
-strcpy(newname + c, filename);
-return newname;
-}
-
-//BldQuotedFullPathName returns the quoted fullpath of a file or ""
-CHAR *FullPathName = BldQuotedFullPathName(CHAR *pathname,
-CHAR *filename)
-{
-
-CHAR newname[CCHMAXPATH] = '\"';
-INT c = 0;
-
-c = strlen(pathname);
-if (c > 0) {
-memcpy(newname + 1, pathname, c + 2);
-if (newname[c + 1] != '\\')
-newname[c + 2] = '\\';
-strcpy(newname + c + 3, filename);
-}
-else
-strcpy(newname + 1, filename)
-strcat(newname, '\"')
-return newname;
-}
-}}}
-
-Not quite. The caller must pass a pointer to the buffer. Keep in mind
-that local variable disappear when the function returns.
-
-
-{{{
-PSZ BldFullPathName(PSZ fullPathName, PSZ dirname, PSZ filename);
-}}}
-
-
-
-{{{
-CHAR newname[CCHMAXPATH] = Nullstr;
-}}}
-
-
-This will give you an error because NullStr is a pointer.
-
-
-{{{
-CHAR newname[CCHMAXPATH];
-}}}
-
-
-Is sufficent since you are always going to copy something. The return is
-
-
-{{{
-return fullPathName
-}}}
-
-
-with the appropriate name changes.
-
-
-{{{
-//BldQuotedFullPathName returns the quoted fullpath of a file or "" CHAR
-}}}
-
-
-The quotes need to be optional and the return buffer needs to be passed as
-above.
-
-
-{{{
-PSZ BldQuotedFullPathName(PSZ fullPathName, PSZ pathname, PSZ filename)
-}}}
-
-
-You also need to add the calls to needs_quotes() a stuff the quotes only
-if needed. This is what the existing inline code does.
-
-=== What is the purpose of quoting functions? ===
-
-Its purpose is to replace repeated occurances of code of the form
-
-
-{{{
-sprintf(cl, "%s %s%s%s", dcd->info->delete,
-(needs_quoting(dcd->arcname)) ? "\"" : NullStr,
-dcd->arcname,
-(needs_quoting(dcd->arcname)) ? "\"" : NullStr);
-}}}
-
-
-and possibly
-
-
-{{{
-runemf2(SEPARATEKEEP | WINDOWED | MAXIMIZED,
-hwnd, NULL, NULL, "%s %s%s%s", ad->info->test,
-needs_quoting(ad->arcname) ? "\"" : NullStr,
-ad->arcname,
-needs_quoting(ad->arcname) ? "\"" : NullStr);
-}}}
-
-
-=== Where is the best place to do a check for? ===
-
-Since the check always needs to be done, it's generally better to do it in
-the function.
-
 ----
 
@@ -226 +99 @@
 
 ----
+
+== Coding Questions == #coding-questions
+
+=== Is the code below OK? Did I account for the terminating nulls correctly? ===
+
+{{{
+//BldFullPathName returns the fullpath of a file or Nullstr
+CHAR *FullPathName = BldFullPathName(CHAR *pathname, CHAR
+*filename)
+{
+
+CHAR newname[CCHMAXPATH] = Nullstr;
+INT c = 0;
+
+c = strlen(pathname);
+if (c > 0) {
+memcpy(newname, pathname, c + 1);
+if (newname[c] != '\\')
+newname[c++] = '\\';
+}
+strcpy(newname + c, filename);
+return newname;
+}
+
+//BldQuotedFullPathName returns the quoted fullpath of a file or ""
+CHAR *FullPathName = BldQuotedFullPathName(CHAR *pathname,
+CHAR *filename)
+{
+
+CHAR newname[CCHMAXPATH] = '\"';
+INT c = 0;
+
+c = strlen(pathname);
+if (c > 0) {
+memcpy(newname + 1, pathname, c + 2);
+if (newname[c + 1] != '\\')
+newname[c + 2] = '\\';
+strcpy(newname + c + 3, filename);
+}
+else
+strcpy(newname + 1, filename)
+strcat(newname, '\"')
+return newname;
+}
+}}}
+
+Not quite. The caller must pass a pointer to the buffer. Keep in mind
+that local variable disappear when the function returns.
+
+
+{{{
+PSZ BldFullPathName(PSZ fullPathName, PSZ dirname, PSZ filename);
+}}}
+
+
+
+{{{
+CHAR newname[CCHMAXPATH] = Nullstr;
+}}}
+
+
+This will give you an error because NullStr is a pointer.
+
+
+{{{
+CHAR newname[CCHMAXPATH];
+}}}
+
+
+Is sufficent since you are always going to copy something. The return is
+
+
+{{{
+return fullPathName
+}}}
+
+
+with the appropriate name changes.
+
+
+{{{
+//BldQuotedFullPathName returns the quoted fullpath of a file or "" CHAR
+}}}
+
+
+The quotes need to be optional and the return buffer needs to be passed as
+above.
+
+
+{{{
+PSZ BldQuotedFullPathName(PSZ fullPathName, PSZ pathname, PSZ filename)
+}}}
+
+
+You also need to add the calls to needs_quotes() a stuff the quotes only
+if needed. This is what the existing inline code does.
+
+=== What is the purpose of quoting functions? ===
+
+Its purpose is to replace repeated occurances of code of the form
+
+
+{{{
+sprintf(cl, "%s %s%s%s", dcd->info->delete,
+(needs_quoting(dcd->arcname)) ? "\"" : NullStr,
+dcd->arcname,
+(needs_quoting(dcd->arcname)) ? "\"" : NullStr);
+}}}
+
+
+and possibly
+
+
+{{{
+runemf2(SEPARATEKEEP | WINDOWED | MAXIMIZED,
+hwnd, NULL, NULL, "%s %s%s%s", ad->info->test,
+needs_quoting(ad->arcname) ? "\"" : NullStr,
+ad->arcname,
+needs_quoting(ad->arcname) ? "\"" : NullStr);
+}}}
+
+
+=== Where is the best place to do a check for? ===
+
+Since the check always needs to be done, it's generally better to do it in
+the function.
+
+
+----