Make searchapath thread-safe

[John Small]

searchapath (in srchpath.c) uses a static array and returns the address of that array to its callers.

Steven has a note (from 2007) in the code to this effect.

[John Small]

To make the function thread-safe, the function's signature will need to change. The new function will: 1) return the return code from DosSearchPath (instead of returning a pointer to a static array as the current code does). 2) require an additional parameter: a pointer to where the function should copy the full filename if the search was successful. Since many calls to the search*path functions do not use about the actual filename, this additional parameter can be set to NULL.

Changing the signature means all the functions which call searchapath and searchpath (which relays calls to searchapath) will have to change. Since all the calls to searchpath and searchapath will change, each function's name will be changed to a more descriptive name: searchapath -- > SearchPathForFile searchpath --> SearchMultiplePathsForFile

[John Small]

CS [1750]

In addition to the changes described in the previous comment, the "checkfile" function's signature was changed to accommodate the changed signatures of searchpath (now SearchMultiplePathsForFile) and searchapath (now SearchPathForFile). . So calls to it were also changed.

[Gregg Young]

Ticket retargeted after milestone closed